mirror of
https://git.kernel.org/pub/scm/network/wireless/iwd.git
synced 2024-11-14 07:59:24 +01:00
c73575585b
Don't use del wd to dereference the IWD instance at the end of the function where it has been defined in the first place as at this point wd is about to have its reference count decreased anyway (the variable's scope is ending) so it's pointless (but didn't hurt). Relying on the __del__ destructor to kill the IWD process in those tests it has been started in the constructor is a bit of a hack in the first place, because the destructor is called on garbage collection and even through CPython does this on the refcount reaching 0, this is not documented and there's no guideline on when it should happen or if it should happen at all. So it could be argued that we should keep the del wd statemenets to be able to easily replace all of them with a call to a new method. But most of them are not placed so that they're guaranteed to happen on test success or failure. It would probably be easier to do this and other housekeeping in a base class and make the tests its subclasses. Also some of these tests don't really need to launch iwd themselves, since IWD now tracks changes in the known network files I think IWD only really needs to be killed between tests when main.conf changes. |
||
|---|---|---|
| .. | ||
| eap-user-peap-gtc.text | ||
| hw.conf | ||
| peap_gtc_nosecret_test.py | ||
| peap_gtc_test.py | ||
| ssidEAP-PEAPv1-GTC-nosecret.8021x | ||
| ssidEAP-PEAPv1-GTC-nosecret.conf | ||
| ssidEAP-PEAPv1-GTC.8021x | ||
| ssidEAP-PEAPv1-GTC.conf | ||