mirror of
https://git.kernel.org/pub/scm/network/wireless/iwd.git
synced 2025-10-31 13:17:25 +01:00
b0e970ae38
There were some major problems related to logging and process output. Tests which required output from start_process would break if used with '--log/--verbose'. This is because we relied on 'communicate' to retrieve the process output, but Popen does not store process output when stdout/stderr are anything other than PIPE. Intead, in the case of logging or outfiles, we can simply read from the file we just wrote to. For an explicit --verbose application we must handle things slightly different. A keyword argument was added to Process, 'need_out' which will ensure the process output is kept regardless of --log or --verbose. Now a user should be able to use --log/--verbose without any tests failing.