Kernel
/
iwd
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git
3
0
Fork 0
Code Releases Activity

eapol: Remove erroneous comments 

The comments quoted sections of the specification that indicated STA
behavior for verifying Message 3 of 4 or GTK 1 of 2.  But in reality the
code directly below simply calculated the MIC for Message 4 of 4 or GTK
2 of 2.
This commit is contained in:
Denis Kenzior 2017-10-16 14:41:57 -05:00
parent dae0abbac8
commit ffbf10fa31
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/eapol.c
View File

@ -1246,12 +1246,6 @@ static void eapol_handle_ptk_3_of_4(struct eapol_sm *sm,
ptk = handshake_state_get_ptk(sm->handshake);
/*
* 802.11-2012, Section 11.6.6.4, step b):
* Verifies the Message 3 MIC. If the calculated MIC does not match
* the MIC that the Authenticator included in the EAPOL-Key frame,
* the Supplicant silently discards Message 3.
*/
if (!eapol_calculate_mic(ptk->kck, step4, mic))
goto fail;
@ -1341,11 +1335,6 @@ static void eapol_handle_gtk_1_of_2(struct eapol_sm *sm,
sm->replay_counter,
sm->handshake->wpa_ie, ek->wpa_key_id);
/*
* 802.11-2012, Section 11.6.7.3, step b):
* Verifies that the MIC is valid, i.e., it uses the KCK that is
* part of the PTK to verify that there is no data integrity error.
*/
ptk = handshake_state_get_ptk(sm->handshake);
if (!eapol_calculate_mic(ptk->kck, step2, mic))