From fbf8ed41401166cacd9283abe17ba114bd0d2f9e Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Wed, 24 Jul 2024 05:14:43 -0700 Subject: [PATCH] auto-t: don't print valgrind log if there was no error If valgrind didn't report any issues, don't dump the logs. This makes the test run a lot easier to look at without having to scroll through pages of valgrind logs that provide no value. --- tools/run-tests | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/run-tests b/tools/run-tests index fdd0b989..e043965b 100755 --- a/tools/run-tests +++ b/tools/run-tests @@ -899,12 +899,18 @@ def post_test(ctx, to_copy): if ctx.args.valgrind: for f in os.listdir('/tmp'): - if f.startswith("valgrind.log."): - dbg(f) - with open('/tmp/' + f, 'r') as v: - dbg(v.read()) + if not f.startswith("valgrind.log."): + continue + + with open('/tmp/' + f, 'r') as v: + result = v.read() + + # Don't print out the result if there were no issues + if "0 errors from 0 contexts" not in result: + dbg(result) dbg("\n") - os.remove('/tmp/' + f) + + os.remove('/tmp/' + f) # Special case for when logging is enabled if os.path.isfile('/tmp/iwd-tls-debug-server-cert.pem'):