Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-22 06:29:23 +01:00
Code Releases Activity

autotests: Fix testNetconfig ACD test

Browse Source 
Part of static_test.py starts a second IWD instance and tries to make
it connect to the AP with the same IP address as the first IWD instance
which is already connected, to produce an IP conflict.  For this, the
second instance uses DHCP and the test expects the DHCP server to offer
the address 192.168.1.10 to it.  However in the current setup the DHCP
server manages to detect that 192.168.1.10 is in use and offers .11
instead.  Break the DHCP server's conflict detection by disabling ICMP
ping replies in order to fix the test.

Previously this has worked because the AP's and the DHCP server's
network interface is in the same network namespace as the first IWD
instance's network interface meaning that pings between the two
interfaces shouldn't work (a known Linux kernel routing quirk...).
I am not sure why those pings currently do work but take no chances and
disable ICMP pings.
This commit is contained in:
Andrew Zaborowski 2022-08-23 18:36:14 +02:00 committed by Denis Kenzior
parent f56d01d25e
commit f6a890f5cb
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
autotests/testNetconfig/static_test.py
View File

@ -85,11 +85,16 @@ class Test(unittest.TestCase):
condition = 'not obj.connected'
wd_ns0.wait_for_object_condition(ordered_network.network_object, condition)
# Connect to the same network from a dynamically configured client. The
# DHCP server doesn't know (even though dev1 announced itself) that
# 192.168.1.10 is already in use and if it assigns dev2 the lowest
# available address, that's going to be 192.168.1.10. dev1's ACD
# implementation should then stop using this address.
# Connect to the same network from a dynamically configured client. We
# block ICMP pings so that the DHCP server can't confirm that
# 192.168.1.10 is in use by dev1 and if it assigns dev2 the lowest
# available address, that's going to be 192.168.1.10. We also keep the
# second client's netdev in a separate namespace so that the kernel
# lets us assign the same IP. dev1's ACD implementation should then
# stop using this address. Yes, a quite unrealistic scenario but this
# lets us test our reaction to a conflict appearing after successful
# initial setup.
os.system("echo 1 > /proc/sys/net/ipv4/icmp_echo_ignore_all")
ordered_network.network_object.connect()
condition = 'obj.state == DeviceState.connected'