From f046bed225e0e9efad3103a4f761ec5956455df2 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Mon, 8 Feb 2021 12:19:58 -0800 Subject: [PATCH] ap: massage code to make static analysis happy There is no functional change here but checking the return value makes static analysis much happier. Checking the return and setting the default inside the if clause is also consistent with how IWD does it many other places. --- src/ap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ap.c b/src/ap.c index 162b456b..407a2596 100644 --- a/src/ap.c +++ b/src/ap.c @@ -3305,7 +3305,7 @@ static void ap_netdev_watch(struct netdev *netdev, static int ap_init(void) { const struct l_settings *settings = iwd_get_config(); - bool dhcp_enable = false; + bool dhcp_enable; netdev_watch = netdev_watch_add(ap_netdev_watch, NULL, NULL); @@ -3320,8 +3320,9 @@ static int ap_init(void) * DHCP server. If no value is found or it is false do not create a * DHCP server. */ - l_settings_get_bool(settings, "General", "EnableNetworkConfiguration", - &dhcp_enable); + if (!l_settings_get_bool(settings, "General", + "EnableNetworkConfiguration", &dhcp_enable)) + dhcp_enable = false; if (dhcp_enable) { L_AUTO_FREE_VAR(char *, ip_prefix);