Kernel
/
iwd
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git
3
0
Fork 0
Code Releases Activity

eap: Re-send Identity Request on EAPoL-Start 

It looks like clients sometimes miss our unsolicited Identity Request
and need a resend.
This commit is contained in:
Andrew Zaborowski 2020-08-27 20:14:44 +02:00 committed by Denis Kenzior
parent a4fa91a695
commit e4b1d4202f
2 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/eap.c
View File

@ -245,10 +245,18 @@ void eap_start(struct eap_state *eap)
{ {
uint8_t buf[5]; uint8_t buf[5];
L_WARN_ON(!eap->method || !eap->authenticator || eap->identity); L_WARN_ON(!eap->method || !eap->authenticator);
/*
* Until we've received the Identity response we can resend the
* Identity request with a constant ID on EAPoL-Start.
*/
if (eap->identity)
return;
eap->last_id = 1;
buf[4] = EAP_TYPE_IDENTITY; buf[4] = EAP_TYPE_IDENTITY;
eap_send_packet(eap, EAP_CODE_REQUEST, ++eap->last_id, buf, 5); eap_send_packet(eap, EAP_CODE_REQUEST, eap->last_id, buf, 5);
} }
void __eap_handle_request(struct eap_state *eap, uint16_t id, void __eap_handle_request(struct eap_state *eap, uint16_t id,

12
src/eapol.c
View File

@ -2239,14 +2239,18 @@ static void eapol_rx_auth_packet(uint16_t proto, const uint8_t *from,
case 1: /* EAPOL-Start */ case 1: /* EAPOL-Start */
/* /*
* The supplicant might have sent an EAPoL-Start even before * The supplicant may have sent an EAPoL-Start even before
* we queued our EAP Identity Request, so this should happen * we queued our EAP Identity Request or it may have missed our
* mostly while we wait for the EAP Identity Response or before. * early Identity Request and may need a retransmission. Tell
* It's safe to ignore this frame in either case. * sm->eap so it can decide whether to send a new Identity
* Request or ignore this.
* *
* TODO: if we're already past the full handshake, send a * TODO: if we're already past the full handshake, send a
* new msg 1/4. * new msg 1/4.
*/ */
if (sm->eap)
eap_start(sm->eap);
break; break;
case 3: /* EAPOL-Key */ case 3: /* EAPOL-Key */