From d6abf629466249d8e871464ffcc350723a6a255c Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Wed, 27 Feb 2019 14:44:15 -0800 Subject: [PATCH] netdev: remove unneeded disconnect for OWE failure If OWE fails in association there is no reason to send a disconnect since its already known that we failed. Instead we can directly call netdev_connect_failed --- src/netdev.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/netdev.c b/src/netdev.c index e4ad9a2d..f098dabd 100644 --- a/src/netdev.c +++ b/src/netdev.c @@ -2600,19 +2600,14 @@ static void netdev_owe_tx_associate(struct iovec *ie_iov, size_t iov_len, static void netdev_owe_complete(uint16_t status, void *user_data) { struct netdev *netdev = user_data; - struct l_genl_msg *msg; if (status) { /* * OWE will never fail during authenticate, at least internally, * so we can always assume its association that failed. */ - netdev->result = NETDEV_RESULT_ASSOCIATION_FAILED; - netdev->last_status_code = status; - msg = netdev_build_cmd_disconnect(netdev, status); - netdev->disconnect_cmd_id = l_genl_family_send(nl80211, msg, - netdev_disconnect_cb, - netdev, NULL); + netdev_connect_failed(netdev, NETDEV_RESULT_ASSOCIATION_FAILED, + status); return; }