From ccf265b943edf5e51206108875cae496e730c1d5 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Mon, 23 Nov 2020 15:05:54 -0800 Subject: [PATCH] netconfig: fix freeing invalid pointer If l_rtnl_ifaddr4_extract does not set the values they would get freed. Instead initialize to NULL so the cleanup free is a no op. --- src/netconfig.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/netconfig.c b/src/netconfig.c index dcb88749..610635cd 100644 --- a/src/netconfig.c +++ b/src/netconfig.c @@ -441,9 +441,9 @@ static void netconfig_ifaddr_added(struct netconfig *netconfig, const struct ifaddrmsg *ifa, uint32_t len) { - L_AUTO_FREE_VAR(char *, label); - L_AUTO_FREE_VAR(char *, ip); - L_AUTO_FREE_VAR(char *, broadcast); + L_AUTO_FREE_VAR(char *, label) = NULL; + L_AUTO_FREE_VAR(char *, ip) = NULL; + L_AUTO_FREE_VAR(char *, broadcast) = NULL; l_rtnl_ifaddr4_extract(ifa, len, &label, &ip, &broadcast); l_debug("%s: ifaddr %s/%u broadcast %s", label,