Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-22 14:49:24 +01:00
Code Releases Activity

test-runner: make --log take a required argument

Browse Source 
This was a mistake in the original implementation. Since test-runner
is always run from the tools directory using --log with no directory
specified would result in many log files being put into the iwd tree.

Instead we can make --log take a required argument so its more
obvious where all the logs are going to go.
This commit is contained in:
James Prestwood 2019-11-13 09:55:50 -08:00 committed by Denis Kenzior
parent 95d4eea68f
commit cb00ae1481
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/test-runner.c
View File

@ -3044,12 +3044,9 @@ static void usage(void)
" test is specified\n" " test is specified\n"
"\t\t\t\tthe 'shell' test" "\t\t\t\tthe 'shell' test"
" will be used\n" " will be used\n"
"\t-l, --log [dir] Directory used for log output. " "\t-l, --log <dir> Directory used for log output. "
"If no directory\n" "This option sets \n"
"\t\t\t\tis specified the " "\t\t\t\t--verbose on all apps");
"current directory will be used\n"
"\t\t\t\tThis option sets --verbose on "
"all apps");
l_info("Commands:\n" l_info("Commands:\n"
"\t-A, --auto-tests <dirs> Comma separated list of the " "\t-A, --auto-tests <dirs> Comma separated list of the "
"test configuration\n\t\t\t\t" "test configuration\n\t\t\t\t"
@ -3069,7 +3066,7 @@ static const struct option main_options[] = {
{ "valgrind", no_argument, NULL, 'V' }, { "valgrind", no_argument, NULL, 'V' },
{ "hw", required_argument, NULL, 'w' }, { "hw", required_argument, NULL, 'w' },
{ "shell", optional_argument, NULL, 's' }, { "shell", optional_argument, NULL, 's' },
{ "log", optional_argument, NULL, 'l' }, { "log", required_argument, NULL, 'l' },
{ "help", no_argument, NULL, 'h' }, { "help", no_argument, NULL, 'h' },
{ } { }
}; };
@ -3100,7 +3097,7 @@ int main(int argc, char *argv[])
for (;;) { for (;;) {
int opt; int opt;
opt = getopt_long(argc, argv, "A:q:k:v:g:UVldh", main_options, opt = getopt_long(argc, argv, "A:q:k:v:g:l:UVdh", main_options,
NULL); NULL);
if (opt < 0) if (opt < 0)
break; break;