Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-25 17:59:25 +01:00
Code Releases Activity

network: enforce max EAP/pkey password length

Browse Source
This commit is contained in:
James Prestwood 2020-03-06 11:16:28 -08:00 committed by Denis Kenzior
parent d40a8d1a6d
commit ca9110e8c2
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/network.c
View File

@ -892,7 +892,15 @@ static void eap_password_callback(enum agent_result result, const char *value,
struct eap_secret_request *req = user_data; struct eap_secret_request *req = user_data;
req->network->agent_request = 0; req->network->agent_request = 0;
if (value) {
if (strlen(value) < IWD_MAX_PASSWORD_LEN)
req->secret->value = l_strdup(value); req->secret->value = l_strdup(value);
else {
l_error("EAP password too long");
result = AGENT_RESULT_FAILED;
}
}
req->callback(result, message, req); req->callback(result, message, req);
} }
@ -910,11 +918,18 @@ static void eap_user_password_callback(enum agent_result result,
size_t len1 = strlen(user) + 1; size_t len1 = strlen(user) + 1;
size_t len2 = strlen(passwd) + 1; size_t len2 = strlen(passwd) + 1;
if (len2 > IWD_MAX_PASSWORD_LEN) {
l_error("EAP password too long");
result = AGENT_RESULT_FAILED;
goto done;
}
req->secret->value = l_malloc(len1 + len2); req->secret->value = l_malloc(len1 + len2);
memcpy(req->secret->value, user, len1); memcpy(req->secret->value, user, len1);
memcpy(req->secret->value + len1, passwd, len2); memcpy(req->secret->value + len1, passwd, len2);
} }
done:
req->callback(result, message, req); req->callback(result, message, req);
} }