From c819903a7cd8ba83e2457c733bda1add659ab15d Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Fri, 18 Feb 2022 11:55:06 -0800 Subject: [PATCH] dpp: check return of aes_siv_encrypt This was caught by static analysis. As is common this should never happen in the real world since the only way this can fail (apart from extreme circumstances like OOM) is if the key size is incorrect, which it will never be. --- src/dpp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/dpp.c b/src/dpp.c index f6ccb926..cedf5bfe 100644 --- a/src/dpp.c +++ b/src/dpp.c @@ -1036,8 +1036,11 @@ static void send_authenticate_response(struct dpp_sm *dpp) * do not use AAD; in other words, the number of AAD components is set * to zero."" */ - aes_siv_encrypt(dpp->ke, dpp->key_len, wrapped2_plaintext, - dpp->key_len + 4, NULL, 0, wrapped2); + if (!aes_siv_encrypt(dpp->ke, dpp->key_len, wrapped2_plaintext, + dpp->key_len + 4, NULL, 0, wrapped2)) { + l_error("Failed to encrypt wrapped data"); + return; + } wrapped2_len += 16;