Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-12-22 13:02:44 +01:00
Code Releases Activity

eap-md5: Memzero copies of secrets

Browse Source
This commit is contained in:
Andrew Zaborowski 2019-03-19 01:25:27 +01:00 committed by Denis Kenzior
parent 8954c62bcf
commit c682847249
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/eap-md5.c
View File

@ -41,6 +41,9 @@ static void eap_md5_free(struct eap_state *eap)
eap_set_data(eap, NULL); eap_set_data(eap, NULL);
if (md5->secret)
explicit_bzero(md5->secret, strlen(md5->secret));
l_free(md5->secret); l_free(md5->secret);
l_free(md5); l_free(md5);
} }
@ -126,6 +129,7 @@ static int eap_md5_check_settings(struct l_settings *settings,
password = l_settings_get_string(settings, "Security", password = l_settings_get_string(settings, "Security",
password_key_old); password_key_old);
if (password) { if (password) {
explicit_bzero(password, strlen(password));
l_warn("Setting '%s' is deprecated, use '%s' instead", l_warn("Setting '%s' is deprecated, use '%s' instead",
password_key_old, password_key); password_key_old, password_key);
return 0; return 0;
@ -139,7 +143,8 @@ static int eap_md5_check_settings(struct l_settings *settings,
eap_append_secret(out_missing, EAP_SECRET_REMOTE_PASSWORD, eap_append_secret(out_missing, EAP_SECRET_REMOTE_PASSWORD,
password_key, NULL, identity, password_key, NULL, identity,
EAP_CACHE_TEMPORARY); EAP_CACHE_TEMPORARY);
} } else
explicit_bzero(password, strlen(password));
return 0; return 0;
} }