From bb4e1ebd4f8f533fe854231bc06d842d8d55843e Mon Sep 17 00:00:00 2001 From: Tim Kourt Date: Thu, 10 Jan 2019 14:34:23 -0800 Subject: [PATCH] eap-mschapv2: Warn if required fields are missing --- src/eap-mschapv2.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/eap-mschapv2.c b/src/eap-mschapv2.c index f79da88c..5fbf0ed2 100644 --- a/src/eap-mschapv2.c +++ b/src/eap-mschapv2.c @@ -556,17 +556,20 @@ static bool eap_mschapv2_load_settings(struct eap_state *eap, snprintf(setting, sizeof(setting), "%sPassword", prefix); password = l_settings_get_string(settings, "Security", setting); - if (password) + if (password) { set_password_from_string(state, password); - else { + } else { unsigned char *tmp; size_t len; const char *hash_str; snprintf(setting, sizeof(setting), "%sPassword-Hash", prefix); hash_str = l_settings_get_value(settings, "Security", setting); - if (!hash_str) + if (!hash_str) { + l_error("Neither '%sPassword' or '%sPassword-Hash' " + "setting was provided", prefix, prefix); goto error; + } tmp = l_util_from_hexstring(hash_str, &len); memcpy(state->password_hash, tmp, 16);