From ab6160b0175fbf74820db13b48287236a5a9bac1 Mon Sep 17 00:00:00 2001 From: Andrew Zaborowski Date: Sat, 22 Sep 2018 18:48:19 +0200 Subject: [PATCH] netdev: Drop DEFAULT_TYPES nl80211 attr of CMD_NEW_KEY The NL80211_ATTR_KEY_DEFAULT_TYPES attribute is only parsed by the kernel if either NL80211_ATTR_KEY_DEFAULT or NL80211_ATTR_KEY_DEFAULT_MGMT are also present, however these are only used with NL80211_CMD_SET_KEY and ignored for NEW_KEY. As far as I understand the default key concept only makes sense for a Tx key because on Rx all keys can be tried, so we don't need this for client mode. The kernel decides whether the NEW_KEY is for unicast or multicast based on whether NL80211_ATTR_KEY_MAC was supplied. --- src/netdev.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/netdev.c b/src/netdev.c index 5bf14e4e..166dbee5 100644 --- a/src/netdev.c +++ b/src/netdev.c @@ -1128,12 +1128,6 @@ static struct l_genl_msg *netdev_build_cmd_new_key_group(struct netdev *netdev, l_genl_msg_append_attr(msg, NL80211_ATTR_KEY_DATA, key_len, key); l_genl_msg_append_attr(msg, NL80211_ATTR_KEY_CIPHER, 4, &cipher); l_genl_msg_append_attr(msg, NL80211_ATTR_KEY_SEQ, ctr_len, ctr); - - l_genl_msg_enter_nested(msg, NL80211_ATTR_KEY_DEFAULT_TYPES); - l_genl_msg_append_attr(msg, NL80211_KEY_DEFAULT_TYPE_MULTICAST, - 0, NULL); - l_genl_msg_leave_nested(msg); - l_genl_msg_append_attr(msg, NL80211_ATTR_KEY_IDX, 1, &key_id); l_genl_msg_append_attr(msg, NL80211_ATTR_IFINDEX, 4, &netdev->index);