3
0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-12-26 01:02:35 +01:00

wscutil: Handle a deprecated network key format

Implement a note from the spec saying that implementations should handle
NUL-terminated Network Keys inside credentials structures.
This commit is contained in:
Andrew Zaborowski 2020-08-13 02:50:11 +02:00 committed by Denis Kenzior
parent 930df7a2b9
commit a95cd4f0fa

View File

@ -362,13 +362,25 @@ static bool extract_network_key(struct wsc_attr_iter *iter, void *data)
{
struct iovec *network_key = data;
unsigned int len;
const uint8_t *key;
len = wsc_attr_iter_get_length(iter);
if (len > 64)
return false;
/*
* WSC 2.0.5, Section 12, Network Key:
* "Some existing implementations based on v1.0h null-terminate the
* passphrase value, i.e., add an extra 0x00 octet into the end of
* the value. For backwards compatibility, implementations shall be
* able to parse such a value"
*/
key = wsc_attr_iter_get_data(iter);
if (len && key[len - 1] == 0x00)
len--;
network_key->iov_len = len;
network_key->iov_base = (void *) wsc_attr_iter_get_data(iter);
network_key->iov_base = (void *) key;
return true;
}