From a943a81f874b043c5e33e630870704aba7a4e2c7 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Tue, 31 Oct 2023 11:47:42 -0700 Subject: [PATCH] dpp: remove scan_periodic_stop calls Stopping periodic scans and not restarting them prevents autoconnect from working again if DPP (or the post-DPP connect) fails. Since the DPP offchannel work is at a higher priority than scanning (and since new offchannels are queue'd before canceling) there is no risk of a scan happening during DPP so its safe to leave periodic scans running. --- src/dpp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/dpp.c b/src/dpp.c index 638d65e0..cfdfaa38 100644 --- a/src/dpp.c +++ b/src/dpp.c @@ -2553,8 +2553,6 @@ static struct l_dbus_message *dpp_dbus_start_enrollee(struct l_dbus *dbus, */ dpp_start_presence(dpp, &freq, 1); - scan_periodic_stop(dpp->wdev_id); - dpp_property_changed_notify(dpp); return NULL; @@ -2685,8 +2683,6 @@ static struct l_dbus_message *dpp_start_configurator_common( network_get_ssid(network), hs->akm_suite); - scan_periodic_stop(dpp->wdev_id); - dpp_property_changed_notify(dpp); l_debug("DPP Start Configurator: %s", dpp->uri);