From 9dce36fe3da54f36e2219098a68cca01d1f95fe7 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Wed, 28 May 2025 12:27:58 -0700 Subject: [PATCH] sae: check return on sae_send_commit() If this fails, in some cases, -EAGAIN would be returned up to netdev which would then assume a retry would be done automatically. This would not in fact happen since it was an internal SAE failure which would result in the connect method return to never get sent. Now if sae_send_commit() fails, return -EPROTO which will cause netdev to fail the connection. --- src/sae.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/sae.c b/src/sae.c index 3305dfdc..87e64041 100644 --- a/src/sae.c +++ b/src/sae.c @@ -994,7 +994,8 @@ static int sae_process_anti_clogging(struct sae_sm *sm, const uint8_t *ptr, sm->token_len = len; sm->sync = 0; - sae_send_commit(sm, true); + if (L_WARN_ON(!sae_send_commit(sm, true))) + return -EPROTO; return -EAGAIN; } @@ -1074,7 +1075,9 @@ static int sae_verify_committed(struct sae_sm *sm, uint16_t transaction, return -ETIMEDOUT; sm->sync++; - sae_send_commit(sm, true); + + if (L_WARN_ON(!sae_send_commit(sm, true))) + return -EPROTO; return -EAGAIN; } @@ -1129,7 +1132,9 @@ static int sae_verify_committed(struct sae_sm *sm, uint16_t transaction, sm->group); sm->sync = 0; - sae_send_commit(sm, false); + + if (L_WARN_ON(!sae_send_commit(sm, false))) + return -EPROTO; return -EAGAIN; } @@ -1294,7 +1299,8 @@ static int sae_verify_confirmed(struct sae_sm *sm, uint16_t trans, sm->sync++; sm->sc++; - sae_send_commit(sm, true); + if (L_WARN_ON(!sae_send_commit(sm, true))) + return -EPROTO; if (!sae_send_confirm(sm)) return -EPROTO;