From 91c449d74a050d50d32341a6eb9665bd0af95501 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Wed, 16 Oct 2019 16:43:02 -0700 Subject: [PATCH] eapol: reorder eapol_sm_free Technically there's no problem here as l_queue_remove does not dereference the pointer. Still, it confuses certain static analysis tools in the current form. Reordering this will not change the behavior at all. --- src/eapol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/eapol.c b/src/eapol.c index 6732b370..cbaf0f4f 100644 --- a/src/eapol.c +++ b/src/eapol.c @@ -886,9 +886,9 @@ struct eapol_sm *eapol_sm_new(struct handshake_state *hs) void eapol_sm_free(struct eapol_sm *sm) { - eapol_sm_destroy(sm); - l_queue_remove(state_machines, sm); + + eapol_sm_destroy(sm); } void eapol_sm_set_listen_interval(struct eapol_sm *sm, uint16_t interval)