From 867c68c05be97842a7efe017c423f1e760adc06d Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Fri, 8 Apr 2022 11:23:28 -0500 Subject: [PATCH] network: close settings prior to network removal station_hide_network will remove and free the network object, so calling network_close_settings will result in a crash. Make sure this is done prior to network object's destruction. Fixes: 85d9d6461f1f ("network: Hide hidden networks on connection error") --- src/network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network.c b/src/network.c index 3f20ada7..65557e41 100644 --- a/src/network.c +++ b/src/network.c @@ -1248,10 +1248,10 @@ static void passphrase_callback(enum agent_result result, return; err: + network_settings_close(network); + if (network->provisioning_hidden) station_hide_network(station, network); - - network_settings_close(network); } static struct l_dbus_message *network_connect_psk(struct network *network,