Kernel
/
iwd
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git
3
0
Fork 0
Code Releases Activity

sae: Fix endianness issues 

The use of mmpdu_authentication and mmpdu_association_response members
marked as __le requires the relevant endianness conversion.
This commit is contained in:
Denis Kenzior 2019-05-23 15:56:08 -05:00
parent 77d66ebc54
commit 85bd019c85
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/sae.c
View File

@ -1031,16 +1031,17 @@ static int sae_rx_authenticate(struct auth_proto *ap,
* code, as well as add the check in the verify function to allow for * code, as well as add the check in the verify function to allow for
* this missing group number. * this missing group number.
*/ */
if (len == 4 && auth->status != if (len == 4 && L_LE16_TO_CPU(auth->status) !=
MMPDU_STATUS_CODE_UNSUPP_FINITE_CYCLIC_GROUP) MMPDU_STATUS_CODE_UNSUPP_FINITE_CYCLIC_GROUP)
goto reject; goto reject;
ret = sae_verify_packet(sm, auth->transaction_sequence, auth->status, ret = sae_verify_packet(sm, L_LE16_TO_CPU(auth->transaction_sequence),
L_LE16_TO_CPU(auth->status),
auth->ies, len - 6); auth->ies, len - 6);
if (ret != 0) if (ret != 0)
return ret; return ret;
switch (auth->transaction_sequence) { switch (L_LE16_TO_CPU(auth->transaction_sequence)) {
case SAE_STATE_COMMITTED: case SAE_STATE_COMMITTED:
return sae_process_commit(sm, hdr->address_2, auth->ies, return sae_process_commit(sm, hdr->address_2, auth->ies,
len - 2); len - 2);
@ -1049,7 +1050,7 @@ static int sae_rx_authenticate(struct auth_proto *ap,
len - 2); len - 2);
default: default:
l_error("invalid transaction sequence %u", l_error("invalid transaction sequence %u",
auth->transaction_sequence); L_LE16_TO_CPU(auth->transaction_sequence));
} }
reject: reject:
@ -1073,7 +1074,7 @@ static int sae_rx_associate(struct auth_proto *ap, const uint8_t *frame,
body = mmpdu_body(mpdu); body = mmpdu_body(mpdu);
if (body->status_code != 0) if (body->status_code != 0)
return (int) body->status_code; return L_LE16_TO_CPU(body->status_code);
return 0; return 0;
} }