From 84ca680611e6a7f7185530f1e6efc210ef91af26 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Fri, 30 Apr 2021 11:31:22 -0500 Subject: [PATCH] netdev: Refine error handling in roam_event --- src/netdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/netdev.c b/src/netdev.c index 232d098d..8ebef99f 100644 --- a/src/netdev.c +++ b/src/netdev.c @@ -4345,7 +4345,8 @@ static void netdev_roam_event(struct l_genl_msg *msg, struct netdev *netdev) netdev->operational = false; - l_genl_attr_init(&attr, msg); + if (!l_genl_attr_init(&attr, msg)) + goto failed; while (l_genl_attr_next(&attr, &type, &len, &data)) { switch (type) { @@ -4387,7 +4388,7 @@ get_fw_scan: return; failed: - l_error("Failed to roam to new BSS"); + l_error("Failed to properly handle the ROAM event -- submit logs!"); netdev_connect_failed(netdev, NETDEV_RESULT_ABORTED, MMPDU_REASON_CODE_UNSPECIFIED);