From 7e9df2cbd59afc3fb7b131be5720a07736e85bb6 Mon Sep 17 00:00:00 2001 From: Tim Kourt Date: Thu, 24 Oct 2019 12:53:55 -0700 Subject: [PATCH] client: Don't check for errors on agent requests method_call and method_reply of type error are mutually exclusive. ell will never forward method_reply messages to dbus services, so checking for dbus_message_has_error is pointless. --- client/agent.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/client/agent.c b/client/agent.c index 5ed6538f..c598d70d 100644 --- a/client/agent.c +++ b/client/agent.c @@ -100,9 +100,6 @@ static struct l_dbus_message *request_passphrase_method_call( struct l_dbus_message *reply; const char *path; - if (dbus_message_has_error(message)) - return NULL; - reply = request_passphrase_command_option(message); if (reply) return reply; @@ -141,9 +138,6 @@ static struct l_dbus_message *request_private_key_passphrase_method_call( struct l_dbus_message *reply; const char *path; - if (dbus_message_has_error(message)) - return NULL; - reply = request_passphrase_command_option(message); if (reply) return reply; @@ -203,9 +197,6 @@ static struct l_dbus_message *request_username_and_password_method_call( struct l_dbus_message *reply; const char *path; - if (dbus_message_has_error(message)) - return NULL; - reply = request_username_and_password_command_option(message); if (reply) return reply; @@ -263,9 +254,6 @@ static struct l_dbus_message *request_user_password_method_call( const char *username; char *username_prompt; - if (dbus_message_has_error(message)) - return NULL; - reply = request_user_password_command_option(message); if (reply) return reply;