Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-25 17:59:25 +01:00
Code Releases Activity

tools: delay hwsim sending frame

Browse Source 
Using mac80211_hwsim can sometimes result in out of order messages
coming from the kernel. Since mac80211_hwsim immediately sends out
frames and the kernel keeps command responses in a separate queue,
bad scheduling can result in these messages being out of order.
In some cases we receive Auth/Assoc frames before the response to
our original CMD_CONNECT. This causes autotests to fail randomly,
some more often than others.

To fix this we can introduce a small delay into hwsim. Just a 1ms
delay makes the random failures disappear in the tests. This delay
is also makes hwsim more realistic since actual hardware will always
introduce some kind of delay when sending or receiving frames.
This commit is contained in:
James Prestwood 2020-05-04 13:16:13 -07:00 committed by Denis Kenzior
parent dfb6f7f025
commit 7641782924
1 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tools/hwsim.c
View File

@ -1350,6 +1350,19 @@ static bool interface_info_match_dst(const void *a, const void *b)
!memcmp(rec->addr, dst->addr, ETH_ALEN); !memcmp(rec->addr, dst->addr, ETH_ALEN);
} }
static void frame_delay_callback(struct l_timeout *timeout, void *user_data)
{
struct send_frame_info *send_info = user_data;
if (send_frame(send_info, send_frame_callback,
send_frame_destroy))
send_info->frame->pending_callback_count++;
else
send_frame_destroy(send_info);
l_timeout_remove(timeout);
}
/* /*
* Process frames in a similar way to how the kernel built-in hwsim medium * Process frames in a similar way to how the kernel built-in hwsim medium
* does this, with an additional optimization for unicast frames and * does this, with an additional optimization for unicast frames and
@ -1409,12 +1422,12 @@ static void process_frame(struct hwsim_frame *frame)
send_info->radio = radio; send_info->radio = radio;
send_info->frame = hwsim_frame_ref(frame); send_info->frame = hwsim_frame_ref(frame);
if (send_frame(send_info, send_frame_callback, if (!l_timeout_create_ms(1, frame_delay_callback,
send_frame_destroy)) send_info, NULL)) {
frame->pending_callback_count++; l_error("Error delaying frame, frame will be dropped");
else
send_frame_destroy(send_info); send_frame_destroy(send_info);
} }
}
hwsim_frame_unref(frame); hwsim_frame_unref(frame);
} }