mirror of
				https://git.kernel.org/pub/scm/network/wireless/iwd.git
				synced 2025-10-31 13:17:25 +01:00 
			
		
		
		
	netdev: remove/update some iwd_notice logs
The iwd_notice function was more meant for special purpose events not general debug prints. For these error conditions we should be using l_warn. For the informational "External Auth to SSID" log we already print this information when connecting from station. In addition there are logs when performing external auth so it should be very obvious external auth is being used without this log.
This commit is contained in:
		
							parent
							
								
									8cf9734d2b
								
							
						
					
					
						commit
						651b647570
					
				
							
								
								
									
										11
									
								
								src/netdev.c
									
									
									
									
									
								
							
							
						
						
									
										11
									
								
								src/netdev.c
									
									
									
									
									
								
							| @ -5522,23 +5522,18 @@ static void netdev_external_auth_event(struct l_genl_msg *msg, | ||||
| 	} | ||||
| 
 | ||||
| 	if (action == NL80211_EXTERNAL_AUTH_ABORT) { | ||||
| 		iwd_notice(IWD_NOTICE_CONNECT_INFO, "External Auth Aborted"); | ||||
| 		l_warn("External Auth Aborted"); | ||||
| 		goto error; | ||||
| 	} | ||||
| 
 | ||||
| 	iwd_notice(IWD_NOTICE_CONNECT_INFO, | ||||
| 			"External Auth to SSID: %s, bssid: "MAC, | ||||
| 			util_ssid_to_utf8(ssid.iov_len, ssid.iov_base), | ||||
| 			MAC_STR(bssid)); | ||||
| 
 | ||||
| 	if (hs->ssid_len != ssid.iov_len || | ||||
| 			memcmp(hs->ssid, ssid.iov_base, hs->ssid_len)) { | ||||
| 		iwd_notice(IWD_NOTICE_CONNECT_INFO, "Target SSID mismatch"); | ||||
| 		l_warn("Target SSID mismatch"); | ||||
| 		goto error; | ||||
| 	} | ||||
| 
 | ||||
| 	if (memcmp(hs->aa, bssid, ETH_ALEN)) { | ||||
| 		iwd_notice(IWD_NOTICE_CONNECT_INFO, "Target BSSID mismatch"); | ||||
| 		l_warn("Target BSSID mismatch"); | ||||
| 		goto error; | ||||
| 	} | ||||
| 
 | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 James Prestwood
						James Prestwood