Kernel
/
iwd
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git
3
0
Fork 0
Code Releases Activity

frame-xchg: Drop l_io read destroy handler 

This function was intended to catch socket errors and destroy the group
but it would leak the l_io object if that happened, and if called on
ordinary shutdown it could cause a crash.  Since we're now assuming
that the netlink socket operations never fail just remove it.
This commit is contained in:
Andrew Zaborowski 2020-03-20 17:20:22 +01:00 committed by Denis Kenzior
parent e705c4382a
commit 59a7f2e681
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/frame-xchg.c
View File

@ -361,19 +361,6 @@ static bool frame_watch_group_io_read(struct l_io *io, void *user_data)
return true;
}
static void frame_watch_group_io_destroy(void *user_data)
{
struct watch_group *group = user_data;
group->io = NULL;
if (l_queue_remove(watch_groups, group)) {
l_error("Frame watch group socket closed");
frame_watch_group_destroy(group);
}
}
static struct watch_group *frame_watch_group_new(uint64_t wdev_id, uint32_t id)
{
struct watch_group *group = l_new(struct watch_group, 1);
@ -435,7 +422,7 @@ static struct watch_group *frame_watch_group_new(uint64_t wdev_id, uint32_t id)
l_io_set_close_on_destroy(group->io, true);
l_io_set_read_handler(group->io, frame_watch_group_io_read, group,
frame_watch_group_io_destroy);
NULL);
group->write_queue = l_queue_new();
return group;