Kernel
/
iwd
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git
3
0
Fork 0
Code Releases Activity

netdev: On connect success don't wait for netdev_operstate_cb 

Send the link_mode and operstate RTNL command in parallel with the
connect Ok event, don't wait for the RTNL callback as it's non-critical.
This commit is contained in:
Andrew Zaborowski 2017-05-30 14:26:19 +02:00 committed by Denis Kenzior
parent 4d20db05d7
commit 55ecda31f3
1 changed files with 9 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/netdev.c
View File

@ -714,23 +714,14 @@ static void netdev_operstate_cb(bool success, void *user_data)
{ {
struct netdev *netdev = user_data; struct netdev *netdev = user_data;
if (!netdev->connected) l_debug("netdev: %d, success: %d", netdev->index, success);
return; }
if (!success) { static void netdev_connect_ok(struct netdev *netdev)
struct l_genl_msg *msg; {
netdev_set_linkmode_and_operstate(netdev->index, IF_LINK_MODE_DORMANT,
l_error("Setting LinkMode and OperState failed for ifindex: %d", IF_OPER_UP, netdev_operstate_cb,
netdev->index); netdev);
netdev->result = NETDEV_RESULT_KEY_SETTING_FAILED;
msg = netdev_build_cmd_deauthenticate(netdev,
MPDU_REASON_CODE_UNSPECIFIED);
netdev->disconnect_cmd_id = l_genl_family_send(nl80211, msg,
netdev_connect_failed,
netdev, NULL);
return;
}
netdev->operational = true; netdev->operational = true;
@ -786,9 +777,7 @@ static void netdev_set_station_cb(struct l_genl_msg *msg, void *user_data)
return; return;
} }
netdev_set_linkmode_and_operstate(netdev->index, IF_LINK_MODE_DORMANT, netdev_connect_ok(netdev);
IF_OPER_UP, netdev_operstate_cb,
netdev);
} }
static struct l_genl_msg *netdev_build_cmd_set_station(struct netdev *netdev) static struct l_genl_msg *netdev_build_cmd_set_station(struct netdev *netdev)
@ -1464,9 +1453,7 @@ static void netdev_connect_event(struct l_genl_msg *msg,
handshake_state_install_ptk(netdev->handshake); handshake_state_install_ptk(netdev->handshake);
} }
netdev_set_linkmode_and_operstate(netdev->index, IF_LINK_MODE_DORMANT, netdev_connect_ok(netdev);
IF_OPER_UP, netdev_operstate_cb,
netdev);
return; return;