Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-22 14:49:24 +01:00
Code Releases Activity

station: re-try OWE if buggy AP is detected

Browse Source 
Some APs use an older hostapd OWE implementation which incorrectly
derives the PTK. To work around this group 19 should be used for
these APs. If there is a failure (reason=2) and the AKM is OWE
set force default group into network and retry. If this has been
done already the behavior is no different and the BSS will be
blacklisted.
This commit is contained in:
James Prestwood 2022-08-08 11:22:59 -07:00 committed by Denis Kenzior
parent 7e99f1343c
commit 5374e44354
1 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/station.c
View File

@ -2815,6 +2815,29 @@ static bool station_try_next_bss(struct station *station)
return true; return true;
} }
static bool station_retry_owe_default_group(struct station *station)
{
/*
* Shouldn't ever get here with classic open networks so its safe to
* assume if the security is none this is an OWE network.
*/
if (network_get_security(station->connected_network) != SECURITY_NONE)
return false;
/* If we already forced group 19, allow the BSS to be blacklisted */
if (network_get_force_default_owe_group(station->connected_network))
return false;
l_warn("Failed to connect to OWE BSS "MAC" possibly because the AP is "
"incorrectly deriving the PTK, this AP should be fixed. "
"Retrying with group 19 as a workaround",
MAC_STR(station->connected_bss->addr));
network_set_force_default_owe_group(station->connected_network);
return true;
}
static bool station_retry_with_reason(struct station *station, static bool station_retry_with_reason(struct station *station,
uint16_t reason_code) uint16_t reason_code)
{ {
@ -2825,12 +2848,20 @@ static bool station_retry_with_reason(struct station *station,
* Other reason codes can be added here if its decided we want to * Other reason codes can be added here if its decided we want to
* fail in those cases. * fail in those cases.
*/ */
if (reason_code == MMPDU_REASON_CODE_PREV_AUTH_NOT_VALID || switch (reason_code) {
reason_code == MMPDU_REASON_CODE_IEEE8021X_FAILED) case MMPDU_REASON_CODE_PREV_AUTH_NOT_VALID:
if (station_retry_owe_default_group(station))
goto try_next;
/* fall through */
case MMPDU_REASON_CODE_IEEE8021X_FAILED:
return false; return false;
default:
break;
}
blacklist_add_bss(station->connected_bss->addr); blacklist_add_bss(station->connected_bss->addr);
try_next:
return station_try_next_bss(station); return station_try_next_bss(station);
} }