Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-11-22 23:09:34 +01:00
Code Releases Activity

frame-xchg: Make debugs a bit more useful

Browse Source 
- Make sure to print the cookie information
- Don't print messages for frames we're not interested in.  This is
  particularly helpful when running auto-tests since frame acks from
  hostapd pollute the iwd log.
This commit is contained in:
Denis Kenzior 2021-04-21 11:03:55 -05:00
parent 1b0f24a283
commit 45dd5d2f7c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/frame-xchg.c
View File

@ -906,8 +906,6 @@ static void frame_xchg_tx_cb(struct l_genl_msg *msg, void *user_data)
fx->tx_cmd_id = 0; fx->tx_cmd_id = 0;
l_debug("err %i", -error);
if (error < 0) { if (error < 0) {
if (error == -EBUSY) { if (error == -EBUSY) {
fx->timeout = l_timeout_create_ms(fx->retry_interval, fx->timeout = l_timeout_create_ms(fx->retry_interval,
@ -926,6 +924,8 @@ static void frame_xchg_tx_cb(struct l_genl_msg *msg, void *user_data)
goto error; goto error;
} }
l_debug("Frame sent, cookie: %"PRIu64" obtained", cookie);
early_status = fx->early_status && cookie == fx->cookie; early_status = fx->early_status && cookie == fx->cookie;
fx->tx_acked = early_status && fx->tx_acked; fx->tx_acked = early_status && fx->tx_acked;
fx->have_cookie = true; fx->have_cookie = true;
@ -1269,13 +1269,14 @@ static void frame_xchg_mlme_notify(struct l_genl_msg *msg, void *user_data)
NL80211_ATTR_UNSPEC) < 0) NL80211_ATTR_UNSPEC) < 0)
return; return;
l_debug("Received %s", ack ? "an ACK" : "no ACK");
fx = l_queue_find(frame_xchgs, frame_xchg_match_running, fx = l_queue_find(frame_xchgs, frame_xchg_match_running,
&wdev_id); &wdev_id);
if (!fx) if (!fx)
return; return;
l_debug("Received %s for cookie: %"PRIu64,
ack ? "an ACK" : "no ACK", cookie);
if (fx->have_cookie && cookie == fx->cookie && !fx->tx_acked) if (fx->have_cookie && cookie == fx->cookie && !fx->tx_acked)
frame_xchg_tx_status(fx, ack); frame_xchg_tx_status(fx, ack);
else if (!fx->have_cookie && !fx->tx_acked) { else if (!fx->have_cookie && !fx->tx_acked) {