netdev: better handle disconnect after FW scan

This should have been updated along with the connect and roam
event separation. Since netdev_connect_event is not being
re-used for CMD_ROAM the comment did not make sense anymore.
Still, there needs to be a check to ensure we were not disconnected
while waiting for GET_SCAN to come back.
This commit is contained in:
James Prestwood 2021-04-02 15:06:14 -07:00 committed by Denis Kenzior
parent 0d6b572ca5
commit 44625373bc
1 changed files with 3 additions and 5 deletions

View File

@ -4099,12 +4099,10 @@ static bool netdev_get_fw_scan_cb(int err, struct l_queue *bss_list,
struct scan_bss *bss = NULL;
/*
* If there was a failure in netdev_connect_event this would reset
* the connect state (netdev_connect_free) causing the sm to be freed.
* In this case we should just ignore this and allow the disconnect
* logic to continue.
* If we happened to be disconnected prior to GET_SCAN coming back
* just bail out now. This disconnect should already have been handled.
*/
if (!netdev->sm)
if (!netdev->connected)
return false;
if (err < 0) {