From 42273fd1228eb27df00fe30a09bc175e0a5ae036 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Tue, 27 Feb 2024 13:16:18 -0800 Subject: [PATCH] station: warn on missing scan_bss in station_transition_start This shouldn't be possible in theory since the roam_bss_list being iterated is a subset of entire scan_bss list station/network has but to be safe, and catch any issues due to future changes warn on this condition. --- src/station.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/station.c b/src/station.c index 477f444a..641068cc 100644 --- a/src/station.c +++ b/src/station.c @@ -2533,6 +2533,8 @@ static void station_transition_start(struct station *station) while ((rbss = l_queue_peek_head(station->roam_bss_list))) { struct scan_bss *bss = network_bss_find_by_addr( station->connected_network, rbss->addr); + if (L_WARN_ON(!bss)) + continue; roaming = station_try_next_transition(station, bss, rbss->ft_failed);