Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2025-02-16 23:30:54 +01:00
Code Releases Activity

rrm: Consider requests w/ Beacon Reporting

Browse Source 
Normally Beacon Reporting subelements are present only if repeated
measurements are requested.  However, an all-zero Beacon Reporting
subelement is included by some implementations.  Handle this case
similarly to the absent case.
This commit is contained in:
Denis Kenzior 2021-10-20 11:49:13 -05:00
parent ae0ee89d72
commit 3dc724d734
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/rrm.c
View File

@ -578,6 +578,11 @@ static void rrm_handle_beacon_request(struct rrm_state *rrm,
detail = l_get_u8(data); detail = l_get_u8(data);
break; break;
case RRM_BEACON_REQ_SUBELEM_ID_BEACON_REPORTING: case RRM_BEACON_REQ_SUBELEM_ID_BEACON_REPORTING:
if (length < 2) {
l_error("Invalid length in Beacon Reporting");
goto reject_refused;
}
/* /*
* 802.11-2016 9.4.2.21.7 * 802.11-2016 9.4.2.21.7
* *
@ -585,9 +590,19 @@ static void rrm_handle_beacon_request(struct rrm_state *rrm,
* present in a Beacon request for repeated * present in a Beacon request for repeated
* measurements; otherwise it is not present" * measurements; otherwise it is not present"
* *
* Since repeated measurements are not supported we can * However, some implementations send an all-zero
* reject this request now. * Beacon Reporting subelement. Reporting Condition
* of zero is 'default, used when the Beacon Reporting
* subelement is not included in a Beacon request).'
* Treat such elements as if they're not present.
*
* Otherwise, since repeated measurements are not
* supported we can reject this request now.
*/ */
if (l_get_u8(data) != 0)
goto reject_incapable;
break;
case RRM_BEACON_REQ_SUBELEM_ID_AP_CHAN_REPORT: case RRM_BEACON_REQ_SUBELEM_ID_AP_CHAN_REPORT:
/* /*
* Only supporting single channel requests * Only supporting single channel requests