From 30158fe89cf9dabc582dece4a738e8cd5800111f Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Thu, 12 Aug 2021 13:21:53 -0700 Subject: [PATCH] test-runner: don't run duplicate tests If the user provides duplicate tests in the list only append one of them to the list. This can happen accidentally when using glob matches. --- tools/test-runner | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/test-runner b/tools/test-runner index 939efa51..28c7d900 100755 --- a/tools/test-runner +++ b/tools/test-runner @@ -1013,15 +1013,17 @@ def build_test_list(args): tests = [test_root + '/' + x for x in full_list[i:] \ if x.startswith('test')] elif os.path.exists(t): - tests.append(t) + if t not in tests: + tests.append(t) elif os.path.exists(path): - tests.append(path) + if path not in tests: + tests.append(path) else: matches = glob(path) if matches == []: raise Exception("Could not find test %s" % t) - tests.extend(matches) + tests.extend(list(set(matches) - set(tests))) return sorted(tests)