From 17ba7e415b33bfd3f757493d7f2e1975d6a6341a Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Mon, 8 Feb 2021 12:19:55 -0800 Subject: [PATCH] client: check mkdir return in display_init Printing a warning is about all that we can do at this point during initialization. --- client/display.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/client/display.c b/client/display.c index 961ad419..4b9ee8f0 100644 --- a/client/display.c +++ b/client/display.c @@ -681,6 +681,7 @@ void display_init(void) { const char *data_home; char *data_path; + int ret; display_refresh.redo_entries = l_queue_new(); @@ -701,7 +702,12 @@ void display_init(void) } if (data_path) { - mkdir(data_path, 0700); + ret = mkdir(data_path, 0700); + /* Not much can be done since display isn't even initialized */ + if (L_WARN_ON(ret < 0)) { + l_free(data_path); + return; + } history_path = l_strdup_printf("%s/history", data_path); read_history(history_path);