Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-12-22 13:02:44 +01:00
Code Releases Activity

dpp: don't allocate transient ssid strings

Browse Source 
These can be kept on the stack and avoid the need for
allocated memory and unneeded auto-free functionality.
This commit is contained in:
James Prestwood 2022-01-07 16:13:28 -08:00 committed by Denis Kenzior
parent 847a8ba265
commit 0f7ea99605
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/dpp.c
View File

@ -400,7 +400,7 @@ static void send_config_result(struct dpp_sm *dpp, const uint8_t *to)
static void dpp_write_config(struct dpp_configuration *config, static void dpp_write_config(struct dpp_configuration *config,
struct network *network) struct network *network)
{ {
_auto_(l_free) char *ssid = l_malloc(config->ssid_len + 1); char ssid[33];
_auto_(l_settings_free) struct l_settings *settings = l_settings_new(); _auto_(l_settings_free) struct l_settings *settings = l_settings_new();
_auto_(l_free) char *path; _auto_(l_free) char *path;
_auto_(l_free) uint8_t *psk = NULL; _auto_(l_free) uint8_t *psk = NULL;
@ -494,7 +494,7 @@ static void dpp_handle_config_response_frame(const struct mmpdu_header *frame,
struct station *station = station_find(netdev_get_ifindex(dpp->netdev)); struct station *station = station_find(netdev_get_ifindex(dpp->netdev));
struct network *network; struct network *network;
struct scan_bss *bss = NULL; struct scan_bss *bss = NULL;
_auto_(l_free) char *ssid = NULL; char ssid[33];
if (dpp->state != DPP_STATE_CONFIGURING) if (dpp->state != DPP_STATE_CONFIGURING)
return; return;
@ -618,7 +618,6 @@ static void dpp_handle_config_response_frame(const struct mmpdu_header *frame,
return; return;
} }
ssid = l_malloc(config->ssid_len + 1);
memcpy(ssid, config->ssid, config->ssid_len); memcpy(ssid, config->ssid, config->ssid_len);
ssid[config->ssid_len] = '\0'; ssid[config->ssid_len] = '\0';