From 0e5d83b3eb8f1970de55401b96b2477ac5bde63c Mon Sep 17 00:00:00 2001 From: Mat Martineau Date: Wed, 30 Mar 2016 15:11:27 -0700 Subject: [PATCH] doc: Recommend --no-signoff for checkpatch.pl --- doc/coding-style.txt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index d2577821..8d3528f6 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -11,11 +11,10 @@ can get a passport for your patch ASAP. First of all, the Wireless daemon coding style must follow every rule for Linux kernel (http://www.kernel.org/doc/Documentation/CodingStyle). There also exists a tool named checkpatch.pl to help you check the compliance -with it. Just type "checkpatch.pl --no-tree patch_name" to check your patch. +with it. Just type "checkpatch.pl --no-tree --no-signoff patch_name" to +check your patch. -In theory, you need to clean up all the warnings and errors except this -one: "ERROR: Missing Signed-off-by: line(s)". The Wirless daemon does not -used Signed-Off lines, so including them is actually an error. In certain +In theory, you need to clean up all the warnings and errors. In certain circumstances one can ignore the 80 character per line limit. This is generally only allowed if the alternative would make the code even less readable.