From 0a8e64623137613cad13cd74cd224c8717ecad24 Mon Sep 17 00:00:00 2001 From: James Prestwood Date: Tue, 11 Feb 2025 11:26:53 -0800 Subject: [PATCH] eap: initialize vendor_id/vendor_type to zero MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes a compiler warning, specifically on ARM/GCC 12.2.0 src/eap.c: In function ‘eap_rx_packet’: src/eap.c:419:57: error: ‘vendor_type’ may be used uninitialized [-Werror=maybe-uninitialized] 419 | (type == EAP_TYPE_EXPANDED && vendor_id == (id) && vendor_type == (t)) | ^~ src/eap.c:429:18: note: ‘vendor_type’ was declared here 429 | uint32_t vendor_type; | ^~~~~~~~~~~ src/eap.c:419:49: error: ‘vendor_id’ may be used uninitialized [-Werror=maybe-uninitialized] 419 | (type == EAP_TYPE_EXPANDED && vendor_id == (id) && vendor_type == (t)) | ^~ src/eap.c:428:18: note: ‘vendor_id’ was declared here 428 | uint32_t vendor_id; | ^~~~~~~~~ --- src/eap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/eap.c b/src/eap.c index 9e924577..1a03fbcb 100644 --- a/src/eap.c +++ b/src/eap.c @@ -425,8 +425,8 @@ static void eap_handle_response(struct eap_state *eap, const uint8_t *pkt, size_t len) { enum eap_type type; - uint32_t vendor_id; - uint32_t vendor_type; + uint32_t vendor_id = 0; + uint32_t vendor_type = 0; enum eap_type our_type = eap->method->request_type; uint32_t our_vendor_id = (eap->method->vendor_id[0] << 16) | (eap->method->vendor_id[1] << 8) |