From 0201cde7cec6f3171c8dff4ee759512c840dd185 Mon Sep 17 00:00:00 2001 From: Andrew Zaborowski Date: Wed, 30 Mar 2022 19:33:58 +0200 Subject: [PATCH] test-runner: Fix checks in exit_vm We check that config is not None but then access config.ctx outside of that if block anyway. Then we do the same for config.ctx and config.ctx.args. Nest the if blocks for the checks to be useful. --- tools/test-runner | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/test-runner b/tools/test-runner index 9bc66419..4ab42317 100755 --- a/tools/test-runner +++ b/tools/test-runner @@ -61,15 +61,15 @@ def exit_vm(): print("Process %s still running!" % p.args[0]) p.kill() - if config.ctx and config.ctx.results: - success = print_results(config.ctx.results) - else: - success = False + if config.ctx and config.ctx.results: + success = print_results(config.ctx.results) + else: + success = False - if config.ctx.args.result: - result = 'PASS' if success else 'FAIL' - with open(config.ctx.args.result, 'w') as f: - f.write(result) + if config.ctx and config.ctx.args.result: + result = 'PASS' if success else 'FAIL' + with open(config.ctx.args.result, 'w') as f: + f.write(result) os.sync()