Kernel/iwd
3
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/wireless/iwd.git synced 2024-12-11 10:49:26 +01:00
Code Releases Activity
d81de65533
iwd/src/netconfig.c

791 lines
21 KiB
C
Raw Normal View History

netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
/*
*
* Wireless daemon for Linux
*
* Copyright (C) 2019 Intel Corporation. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*
*/
#ifdef HAVE_CONFIG_H
#include <config.h>
#endif
#include <errno.h>
netconfig: Introduce IPv4 DHCP client The client is used to obtain and configure the dynamic IPv4 addresses for the network.
2019-06-26 00:20:56 +02:00
#include <arpa/inet.h>
netconfig: Use different includes that also work on older systems
2019-08-02 20:33:43 +02:00
#include <net/if_arp.h>
#include <netinet/in.h>
netconfig: Start RA & DHCPv6 clients For now the RA client is ran automatically when DHCPv6 client starts. RA takes care of installing / deleting prefix routes and installing the default gateway. If Router Advertisements indicate support DHCPv6, then DHCPv6 transactions are kicked off and the address is set / removed automatically. Stateless configuration is not yet supported.
2020-11-05 16:38:32 +01:00
#include <limits.h>
#include <string.h>
#include <fcntl.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
#include <ell/ell.h>
treewide: Use ell's useful.h header
2021-03-12 04:46:09 +01:00
#include "ell/useful.h"
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
#include "src/iwd.h"
module: Move declarations into separate header file
2019-11-07 23:33:51 +01:00
#include "src/module.h"
netconfig: Introduce IPv4 DHCP client The client is used to obtain and configure the dynamic IPv4 addresses for the network.
2019-06-26 00:20:56 +02:00
#include "src/netdev.h"
#include "src/station.h"
netconfig: Enable config. with static IPv4 addresses
2019-06-26 00:21:00 +02:00
#include "src/common.h"
#include "src/network.h"
resolve: Introduce resolve module The module is responsible for the configuration of the address resolution services. It will consist of the multiple service specific plugins such as: systemd-resolved plugin, dnsmasq plugin, etc.
2019-07-03 01:14:50 +02:00
#include "src/resolve.h"
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
#include "src/util.h"
netconfig: FILS IP assigment API Add two methods that will allow station to implement FILS IP Address Assigment, one method to decide whether to send the request during association, and fill in the values to be used in the request IE, and another to handle the response IE values received from the server and apply them. The netconfig->rtm_protocol value used when the address is assigned this way remains RTPROT_DHCP because from the user's point of view this is automatic IP assigment by the server, a replacement for DHCP.
2021-08-27 05:02:04 +02:00
#include "src/ie.h"
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
#include "src/netconfig.h"
netconfig: remove sysfs static functions
2021-11-03 23:15:00 +01:00
#include "src/sysfs.h"
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
netconfig: limit DHCPv4 attempts to avoid extended netconfig times ELL now has a setting to limit the number of DHCP attempts. This will now be set in IWD and if reached will result in a failure event, and in turn a disconnect. IWD will set a maximum of 4 retries which should keep the maximum DHCP time to ~60 seconds roughly.
2024-01-30 18:50:37 +01:00
#define DHCP_ATTEMPTS 4
netconfig: make ROUTE_PRIORITY_OFFSET a uint32_t Also move it up into the static variable block
2019-07-31 19:38:40 +02:00
/*
* Routing priority offset, configurable in main.conf. The route with lower
* priority offset is preferred.
*/
static uint32_t ROUTE_PRIORITY_OFFSET;
netconfig: Add configs for controlling IPV6 support
2020-11-13 22:24:17 +01:00
static bool ipv6_enabled;
netconfig: add global MulticastDNS option Adds the MulticastDNS option globally to main.conf. If set all network connections (when netconfig is enabled) will set mDNS support into the resolver. Note that an individual network profile can still override the global value if it sets MulticastDNS.
2022-11-03 19:54:06 +01:00
static char *mdns_global;
netconfig: make ROUTE_PRIORITY_OFFSET a uint32_t Also move it up into the static variable block
2019-07-31 19:38:40 +02:00
netconfig: Subscribe for IPv4 link address notifications iwd keeps track of the addresses assigned to the managed interfaces. The list of assigned IPv4/IPv6 addresses is stored in ifaddr_list inside of netconfig. The tracking of the IP addresses will help to remove them from an interface once they are no longer valid.
2019-06-26 00:20:54 +02:00
static void do_debug(const char *str, void *user_data)
{
const char *prefix = user_data;
l_info("%s%s", prefix, str);
}
netconfig: Allow consecutive calls to _load_settings() Make consecutive calls to netconfig_load_settings() memory-leak safe by introducing a netconfig_free_settings convenience method. This method will free any settings that are allocated as a result of netconfig_load_settings() and will be called from netconfig_free() to ensure that any settings are freed as a result of netconfig_destroy().
2021-09-29 22:54:41 +02:00
static void netconfig_free_settings(struct netconfig *netconfig)
{
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
netconfig->enabled[0] = true;
netconfig->enabled[1] = false;
netconfig->static_config[0] = false;
netconfig->static_config[1] = false;
netconfig->gateway_overridden[0] = false;
netconfig->gateway_overridden[1] = false;
netconfig->dns_overridden[0] = false;
netconfig->dns_overridden[1] = false;
l_netconfig_reset_config(netconfig->nc);
netconfig: Apply MDNS setting at _configure time
2021-09-29 23:06:52 +02:00
l_free(netconfig->mdns);
netconfig->mdns = NULL;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
l_free(l_steal_ptr(netconfig->fils_override));
netconfig: Allow consecutive calls to _load_settings() Make consecutive calls to netconfig_load_settings() memory-leak safe by introducing a netconfig_free_settings convenience method. This method will free any settings that are allocated as a result of netconfig_load_settings() and will be called from netconfig_free() to ensure that any settings are freed as a result of netconfig_destroy().
2021-09-29 22:54:41 +02:00
}
netconfig: Rename netconfig destructor The old name will be repurposed for the API.
2019-09-27 21:52:16 +02:00
static void netconfig_free(void *data)
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
{
struct netconfig *netconfig = data;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
l_netconfig_destroy(netconfig->nc);
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
l_free(netconfig);
}
netconfig: Re-add FILS handling Load the settings from FILS IE data into our l_netconfig instance when appropriate.
2022-08-29 19:35:59 +02:00
static bool netconfig_addr_to_str(uint8_t af, const void *v4_addr,
const void *v6_addr, char *out_str,
bool *out_is_zero)
{
const void *addr = (af == AF_INET ? v4_addr : v6_addr);
uint8_t bytes = (af == AF_INET ? 4 : 16);
if (l_memeqzero(addr, bytes)) {
*out_is_zero = true;
return true;
}
*out_is_zero = false;
if (L_WARN_ON(!inet_ntop(af, addr, out_str, INET6_ADDRSTRLEN)))
return false;
return true;
}
netconfig: Add netconfig-commit API Add netconfig-commit.c whose main method, netconfig_commit actually sets the configuration obtained by l_netconfig to the system netdev, specifically it sets local addresses on the interface, adds routes to the routing table, sets DNS related data and may add entries to the neighbor cache. netconfig-commit.c uses a backend-ops type structure to allow for switching backends. In this commit there's only a default backend that uses l_netconfig_rtnl_apply() and a struct resolve object to write the configuration. netconfig_gateway_to_arp is moved from netconfig.c to netconfig-commit.c (and renamed.) The struct netconfig definition is moved to netconfig.h so that both files can access the settings stored in the struct.
2022-08-29 19:35:57 +02:00
bool netconfig_use_fils_addr(struct netconfig *netconfig, int af)
netconfig: Move FILS override checks to common functions
2021-11-08 12:28:31 +01:00
{
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!netconfig->enabled[INDEX_FOR_AF(af)])
return false;
if (netconfig->static_config[INDEX_FOR_AF(af)])
netconfig: Move FILS override checks to common functions
2021-11-08 12:28:31 +01:00
return false;
if (!netconfig->fils_override)
return false;
if (af == AF_INET)
return !!netconfig->fils_override->ipv4_addr;
return !l_memeqzero(netconfig->fils_override->ipv6_addr, 16);
}
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
static struct l_rtnl_address *netconfig_get_static4_address(
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
const struct l_settings *active_settings)
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
{
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
_auto_(l_rtnl_address_free) struct l_rtnl_address *ifaddr = NULL;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
L_AUTO_FREE_VAR(char *, ip) = NULL;
L_AUTO_FREE_VAR(char *, netmask) = NULL;
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
struct in_addr in_addr;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
L_AUTO_FREE_VAR(char *, broadcast) = NULL;
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
uint32_t prefix_len;
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
ip = l_settings_get_string(active_settings, "IPv4", "Address");
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
if (unlikely(!ip)) {
l_error("netconfig: Can't load IPv4.Address");
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
return NULL;
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
}
if (l_settings_has_key(active_settings, "IPv4", "Netmask") &&
!(netmask = l_settings_get_string(active_settings,
"IPv4",
"Netmask"))) {
l_error("netconfig: Can't load IPv4.Netmask");
return NULL;
}
netconfig: Use CamelCase for IPv4 address settings
2019-12-11 00:38:32 +01:00
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
if (netmask) {
if (inet_pton(AF_INET, netmask, &in_addr) != 1) {
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
l_error("netconfig: Can't parse IPv4.Netmask");
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
return NULL;
}
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
prefix_len = __builtin_popcountl(in_addr.s_addr);
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
if (ntohl(in_addr.s_addr) !=
util_netmask_from_prefix(prefix_len)) {
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
l_error("netconfig: Invalid IPv4.Netmask");
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
return NULL;
}
} else
prefix_len = 24;
netconfig: Use CamelCase for IPv4 address settings
2019-12-11 00:38:32 +01:00
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
ifaddr = l_rtnl_address_new(ip, prefix_len);
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
if (!ifaddr || l_rtnl_address_get_family(ifaddr) != AF_INET) {
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
l_error("netconfig: Unable to parse IPv4.Address");
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
return NULL;
}
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
broadcast = l_settings_get_string(active_settings, "IPv4", "Broadcast");
if (broadcast && !l_rtnl_address_set_broadcast(ifaddr, broadcast)) {
l_error("netconfig: Unable to parse IPv4.Broadcast");
return NULL;
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
}
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
return l_steal_ptr(ifaddr);
netconfig: Add helper for IPv4 addresses netconfig_ipv4_get_ifaddr helper function allows to fetch IPv4 addresses from static or dynamic sources. The origin of the addresses is noted in 'ipv4_is_static' flag.
2019-07-31 03:16:05 +02:00
}
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
static struct l_rtnl_address *netconfig_get_static6_address(
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
const struct l_settings *active_settings)
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
{
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
L_AUTO_FREE_VAR(char *, ip);
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
char *p;
netconfig: Fix address format validation Drop the wrong negation in the error check. Check that there are no extra characters after prefix length suffix. Reset errno 0 before the strtoul call, as recommended by the manpage.
2022-06-16 02:02:17 +02:00
char *endp;
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
_auto_(l_rtnl_address_free) struct l_rtnl_address *ret = NULL;
uint32_t prefix_len = 64;
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
ip = l_settings_get_string(active_settings, "IPv6", "Address");
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
if (unlikely(!ip)) {
l_error("netconfig: Can't load IPv6.Address");
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
return NULL;
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
}
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
p = strrchr(ip, '/');
if (!p)
goto no_prefix_len;
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
*p = '\0';
if (*++p == '\0')
goto no_prefix_len;
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
netconfig: Fix address format validation Drop the wrong negation in the error check. Check that there are no extra characters after prefix length suffix. Reset errno 0 before the strtoul call, as recommended by the manpage.
2022-06-16 02:02:17 +02:00
errno = 0;
prefix_len = strtoul(p, &endp, 10);
if (unlikely(*endp != '\0' || errno ||
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
!prefix_len || prefix_len > 128)) {
netconfig: trivial: Fix double-empty space
2021-10-21 10:50:32 +02:00
l_error("netconfig: Invalid prefix '%s' provided in network"
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
" configuration file", p);
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
return NULL;
}
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
no_prefix_len:
ret = l_rtnl_address_new(ip, prefix_len);
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
if (!ret || l_rtnl_address_get_family(ret) != AF_INET6) {
l_error("netconfig: Invalid IPv6 address %s provided in "
"network configuration file.", ip);
return NULL;
}
netconfig: Rework static IPv6 address handling This patch converts the code to use the new l_rtnl_address class. The settings parsing code will now return an l_rtnl_address object which can be installed directly. Also, address removal path for static addresses has been removed, since netconfig_reset() sets disable_ipv6 setting to '1', which will remove all IPV6 addresses for the interface.
2020-11-19 20:26:03 +01:00
netconfig: Clean up netconfig_get_static{4,6}_address * make the error handling simpler, * make error messages more consistent, * validate address families, * for IPv4 skip l_rtnl_address_set_noprefixroute() as l_netconfig will do this internally as needed. * for IPv6 set the default prefix length to 64 as that's going to be used for the local prefix route's prefix length and is a more practical value.
2022-08-29 19:35:55 +02:00
return l_steal_ptr(ret);
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
static bool netconfig_load_dns(struct netconfig *netconfig,
const struct l_settings *active_settings,
const char *group_name, uint8_t family)
netconfig: Do not leak l_acd if static IP is used ==209== by 0x43E48A: netconfig_ipv4_select_and_install (netconfig.c:887) ==209== by 0x43E48A: netconfig_configure (netconfig.c:1025) ==209== by 0x41743C: station_connect_cb (station.c:2556) ==209== by 0x408E0D: netdev_connect_ok (netdev.c:1311) ==209== by 0x47549E: process_unicast (genl.c:994) ==209== by 0x47549E: received_data (genl.c:1102) ==209== by 0x4720EB: io_callback (io.c:120) ==209== by 0x47130C: l_main_iterate (main.c:478) ==209== by 0x4713DB: l_main_run (main.c:525) ==209== by 0x4713DB: l_main_run (main.c:507) ==209== by 0x4715EB: l_main_run_with_signal (main.c:647) ==209== by 0x403EE1: main (main.c:550)
2021-05-19 20:50:56 +02:00
{
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
_auto_(l_strv_free) char **dns_str_list = NULL;
netconfig: Do not leak l_acd if static IP is used ==209== by 0x43E48A: netconfig_ipv4_select_and_install (netconfig.c:887) ==209== by 0x43E48A: netconfig_configure (netconfig.c:1025) ==209== by 0x41743C: station_connect_cb (station.c:2556) ==209== by 0x408E0D: netdev_connect_ok (netdev.c:1311) ==209== by 0x47549E: process_unicast (genl.c:994) ==209== by 0x47549E: received_data (genl.c:1102) ==209== by 0x4720EB: io_callback (io.c:120) ==209== by 0x47130C: l_main_iterate (main.c:478) ==209== by 0x4713DB: l_main_run (main.c:525) ==209== by 0x4713DB: l_main_run (main.c:507) ==209== by 0x4715EB: l_main_run_with_signal (main.c:647) ==209== by 0x403EE1: main (main.c:550)
2021-05-19 20:50:56 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!l_settings_has_key(active_settings, group_name, "DNS"))
return true;
netconfig: Do not leak l_acd if static IP is used ==209== by 0x43E48A: netconfig_ipv4_select_and_install (netconfig.c:887) ==209== by 0x43E48A: netconfig_configure (netconfig.c:1025) ==209== by 0x41743C: station_connect_cb (station.c:2556) ==209== by 0x408E0D: netdev_connect_ok (netdev.c:1311) ==209== by 0x47549E: process_unicast (genl.c:994) ==209== by 0x47549E: received_data (genl.c:1102) ==209== by 0x4720EB: io_callback (io.c:120) ==209== by 0x47130C: l_main_iterate (main.c:478) ==209== by 0x4713DB: l_main_run (main.c:525) ==209== by 0x4713DB: l_main_run (main.c:507) ==209== by 0x4715EB: l_main_run_with_signal (main.c:647) ==209== by 0x403EE1: main (main.c:550)
2021-05-19 20:50:56 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
dns_str_list = l_settings_get_string_list(active_settings,
group_name, "DNS", ' ');
if (unlikely(!dns_str_list)) {
l_error("netconfig: Can't load [%s].DNS", group_name);
return false;
}
netconfig: Track local domains lists Cache the latest v4 and v6 domain string lists in struct netconfig state to be able to more easily detect changes in those values in future commits. For that split netconfig_set_domains's code into this function, which now only commits the values in netconfig->v{4,6}_domain{,s} to the resolver, and netconfig_domains_update() which figures out the active domains string list and saves it into netconfig->v{4,6}_domain{,s}. This probably saves some cycles as the callers can now decide to only recalculate the domains list which may have changed. While there simplify netconfig_set_domains return type to void as the result was always 0 anyway and was never checked by callers.
2021-10-21 10:50:34 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (unlikely(!l_netconfig_set_dns_override(netconfig->nc, family,
dns_str_list))) {
l_error("netconfig: l_netconfig_set_dns_override(%s) failed",
family == AF_INET ? "AF_INET" : "AF_INET6");
return false;
netconfig: add ACD client for static configuration When the IP is configured to be static we can now use ACD in order to check that the IP is available and not already in use. If a conflict is found netconfig will be reset and no IP will be set on the interface. The ACD client is left with the default 'defend once' policy, and probes are not turned off. This will increase connection time, but for static IP's it is the best approach.
2020-12-10 22:22:09 +01:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
netconfig->dns_overridden[INDEX_FOR_AF(family)] = true;
return true;
netconfig: add ACD client for static configuration When the IP is configured to be static we can now use ACD in order to check that the IP is available and not already in use. If a conflict is found netconfig will be reset and no IP will be set on the interface. The ACD client is left with the default 'defend once' policy, and probes are not turned off. This will increase connection time, but for static IP's it is the best approach.
2020-12-10 22:22:09 +01:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
static bool netconfig_load_gateway(struct netconfig *netconfig,
const struct l_settings *active_settings,
const char *group_name, uint8_t family)
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
{
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
_auto_(l_free) char *gateway_str = NULL;
if (!l_settings_has_key(active_settings, group_name, "Gateway"))
return true;
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
gateway_str = l_settings_get_string(active_settings, group_name,
"Gateway");
if (unlikely(!gateway_str)) {
l_error("netconfig: Can't load [%s].Gateway", group_name);
return false;
}
if (unlikely(!l_netconfig_set_gateway_override(netconfig->nc, family,
gateway_str))) {
l_error("netconfig: l_netconfig_set_gateway_override(%s) "
"failed", family == AF_INET ? "AF_INET" : "AF_INET6");
return false;
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
netconfig->gateway_overridden[INDEX_FOR_AF(family)] = true;
return true;
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
}
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
bool netconfig_load_settings(struct netconfig *netconfig,
netconfig: Set address at configure time netconfig_load_settings is called when establishing a new initial association to a network. This function tries to update dhcp/dhcpv6 clients with the MAC address of the netdev being used. However, it is too early to update the MAC here since netdev might need to powercycle the underlying network device in order to update the MAC (i.e. when AddressRandomization="network" is used). If the MAC is set incorrectly, DHCP clients are unable to obtain the lease properly and station is stuck in "connecting" mode indefinitely. Fix this by delaying MAC address update until netconfig_configure() is invoked. Fixes: ad228461abbf ("netconfig: Move loading settings to new method, refactor")
2021-09-27 18:21:40 +02:00
const struct l_settings *active_settings)
netconfig: Add station state watch netconfig is interested in three station states: connected, disconnected and connected after it has roamed. On connected it tries to obtain a new DHCP lease, on disconnected it stops the DHCP client and discards all addresses from interface, on connected after roaming it will try to request a previously issued address.
2019-06-26 00:20:57 +02:00
{
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
bool send_hostname = false;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
char hostname[HOST_NAME_MAX + 1];
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
_auto_(l_free) char *mdns = NULL;
bool success = true;
bool static_ipv4 = false;
bool static_ipv6 = false;
bool enable_ipv4 = true;
bool enable_ipv6 = ipv6_enabled;
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
netconfig_free_settings(netconfig);
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
/*
* Note we try to print errors and continue validating the
* configuration until we've gone through all the settings so
* as to make fixing the settings more efficient for the user.
*/
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (l_settings_has_key(active_settings, "IPv4", "Address")) {
_auto_(l_rtnl_address_free) struct l_rtnl_address *addr =
netconfig_get_static4_address(active_settings);
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (unlikely(!addr)) {
success = false;
goto ipv6_addr;
}
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!l_netconfig_set_static_addr(netconfig->nc, AF_INET,
addr)) {
l_error("netconfig: l_netconfig_set_static_addr("
"AF_INET) failed");
success = false;
goto ipv6_addr;
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
static_ipv4 = true;
netconfig: Install DNS addresses obtained from DHCPv6 This also changes the resolve API a little bit to act as a 'set' API instead of an incremental 'add' API. This is actually easier to manage in the resolve module since both systemd and resolvconf want changes wholesale and not incrementally.
2020-11-18 16:58:28 +01:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
ipv6_addr:
if (l_settings_has_key(active_settings, "IPv6", "Address")) {
_auto_(l_rtnl_address_free) struct l_rtnl_address *addr =
netconfig_get_static6_address(active_settings);
if (unlikely(!addr)) {
success = false;
goto gateway;
}
Send hostname as part of DHCP request. This is based on a previous patch by Roberto Santalla Fernández. A new config is introduced into the network config file under IPv4 called SendHostname. If this is set to true then we add the hostname into all DHCP requests. The default is false.
2021-06-18 19:40:46 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!l_netconfig_set_static_addr(netconfig->nc, AF_INET6,
addr)) {
l_error("netconfig: l_netconfig_set_static_addr("
"AF_INET6) failed");
success = false;
goto gateway;
Send hostname as part of DHCP request. This is based on a previous patch by Roberto Santalla Fernández. A new config is introduced into the network config file under IPv4 called SendHostname. If this is set to true then we add the hostname into all DHCP requests. The default is false.
2021-06-18 19:40:46 +02:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
static_ipv6 = true;
Send hostname as part of DHCP request. This is based on a previous patch by Roberto Santalla Fernández. A new config is introduced into the network config file under IPv4 called SendHostname. If this is set to true then we add the hostname into all DHCP requests. The default is false.
2021-06-18 19:40:46 +02:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
gateway:
if (!netconfig_load_gateway(netconfig, active_settings,
"IPv4", AF_INET))
success = false;
netconfig: Enable config. with static IPv4 addresses
2019-06-26 00:21:00 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!netconfig_load_gateway(netconfig, active_settings,
"IPv6", AF_INET6))
success = false;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!netconfig_load_dns(netconfig, active_settings, "IPv4", AF_INET))
success = false;
if (!netconfig_load_dns(netconfig, active_settings, "IPv6", AF_INET6))
success = false;
if (l_settings_has_key(active_settings, "IPv6", "Enabled") &&
!l_settings_get_bool(active_settings, "IPv6", "Enabled",
&enable_ipv6)) {
l_error("netconfig: Can't load IPv6.Enabled");
success = false;
goto send_hostname;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!l_netconfig_set_family_enabled(netconfig->nc, AF_INET,
enable_ipv4) ||
!l_netconfig_set_family_enabled(netconfig->nc, AF_INET6,
enable_ipv6)) {
l_error("netconfig: l_netconfig_set_family_enabled() failed");
success = false;
}
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
send_hostname:
if (l_settings_has_key(active_settings, "IPv4", "SendHostname") &&
!l_settings_get_bool(active_settings, "IPv4",
"SendHostname",
&send_hostname)) {
l_error("netconfig: Can't load [IPv4].SendHostname");
success = false;
goto mdns;
}
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (send_hostname && gethostname(hostname, sizeof(hostname)) != 0) {
/* Warning only */
l_warn("netconfig: Unable to get hostname. "
"Error %d: %s", errno, strerror(errno));
goto mdns;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (send_hostname &&
!l_netconfig_set_hostname(netconfig->nc, hostname)) {
l_error("netconfig: l_netconfig_set_hostname() failed");
success = false;
goto mdns;
}
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
mdns:
netconfig: add global MulticastDNS option Adds the MulticastDNS option globally to main.conf. If set all network connections (when netconfig is enabled) will set mDNS support into the resolver. Note that an individual network profile can still override the global value if it sets MulticastDNS.
2022-11-03 19:54:06 +01:00
/* If the networks has this set take that over the global */
if (l_settings_has_key(active_settings, "Network", "MulticastDNS")) {
mdns = l_settings_get_string(active_settings, "Network",
"MulticastDNS");
if (!mdns) {
l_error("netconfig: Can't load Network.MulticastDNS");
success = false;
}
if (mdns && !L_IN_STRSET(mdns, "true", "false", "resolve")) {
l_error("netconfig: Bad profile Network.MulticastDNS "
"value '%s'", mdns);
success = false;
}
if (!success)
netconfig: Don't load settings in netconfig_new Move the l_netconfig_set_route_priority() and l_netconfig_set_optimistic_dad_enabled() calls from netconfig_new, which is called once for the l_netconfig object's lifetime, to netconfig_load_settings, which is called before every connection attempt. This is needed because we clean up the l_netconfig configuration by calling l_netconfig_reset_config() at different points in connection setup and teardown so we'd reset the route priority that we've set in netconfig_new, back to 0 and never reload it.
2022-12-22 03:41:43 +01:00
goto route_priority;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
}
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig: add global MulticastDNS option Adds the MulticastDNS option globally to main.conf. If set all network connections (when netconfig is enabled) will set mDNS support into the resolver. Note that an individual network profile can still override the global value if it sets MulticastDNS.
2022-11-03 19:54:06 +01:00
if (!mdns && mdns_global) {
mdns = l_strdup(mdns_global);
if (!L_IN_STRSET(mdns, "true", "false", "resolve")) {
l_error("netconfig: Bad global Network.MulticastDNS "
"value '%s'", mdns);
success = false;
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
}
netconfig: Allow consecutive calls to _load_settings() Make consecutive calls to netconfig_load_settings() memory-leak safe by introducing a netconfig_free_settings convenience method. This method will free any settings that are allocated as a result of netconfig_load_settings() and will be called from netconfig_free() to ensure that any settings are freed as a result of netconfig_destroy().
2021-09-29 22:54:41 +02:00
netconfig: Don't load settings in netconfig_new Move the l_netconfig_set_route_priority() and l_netconfig_set_optimistic_dad_enabled() calls from netconfig_new, which is called once for the l_netconfig object's lifetime, to netconfig_load_settings, which is called before every connection attempt. This is needed because we clean up the l_netconfig configuration by calling l_netconfig_reset_config() at different points in connection setup and teardown so we'd reset the route priority that we've set in netconfig_new, back to 0 and never reload it.
2022-12-22 03:41:43 +01:00
route_priority:
l_netconfig_set_route_priority(netconfig->nc, ROUTE_PRIORITY_OFFSET);
l_netconfig_set_optimistic_dad_enabled(netconfig->nc, true);
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!l_netconfig_check_config(netconfig->nc)) {
l_error("netconfig: Invalid configuration");
success = false;
}
netconfig: Allow consecutive calls to _load_settings() Make consecutive calls to netconfig_load_settings() memory-leak safe by introducing a netconfig_free_settings convenience method. This method will free any settings that are allocated as a result of netconfig_load_settings() and will be called from netconfig_free() to ensure that any settings are freed as a result of netconfig_destroy().
2021-09-29 22:54:41 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (success) {
netconfig->active_settings = active_settings;
netconfig->static_config[INDEX_FOR_AF(AF_INET)] = static_ipv4;
netconfig->static_config[INDEX_FOR_AF(AF_INET6)] = static_ipv6;
netconfig->enabled[INDEX_FOR_AF(AF_INET)] = enable_ipv4;
netconfig->enabled[INDEX_FOR_AF(AF_INET6)] = enable_ipv6;
netconfig->mdns = l_steal_ptr(mdns);
return true;
}
netconfig: Cache the IPv6 l_rtnl_address object For symmetry with netconfig->v4_address add a netconfig->v6_address so that we can track what the current address is at any time.
2021-10-21 10:50:31 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
l_netconfig_reset_config(netconfig->nc);
return false;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
}
netconfig: Re-add FILS handling Load the settings from FILS IE data into our l_netconfig instance when appropriate.
2022-08-29 19:35:59 +02:00
static bool netconfig_load_fils_settings(struct netconfig *netconfig,
uint8_t af)
{
struct ie_fils_ip_addr_response_info *fils = netconfig->fils_override;
char addr_str[INET6_ADDRSTRLEN];
char gw_addr_str[INET6_ADDRSTRLEN];
char dns_addr_str[INET6_ADDRSTRLEN];
_auto_(l_rtnl_address_free) struct l_rtnl_address *rtnl_addr = NULL;
bool is_zero = false;
uint8_t prefix_len;
if (!netconfig_addr_to_str(af, &fils->ipv4_addr, &fils->ipv6_addr,
addr_str, &is_zero) || is_zero)
return is_zero;
prefix_len = (af == AF_INET ? fils->ipv4_prefix_len :
fils->ipv6_prefix_len);
if (L_WARN_ON(!(rtnl_addr = l_rtnl_address_new(addr_str, prefix_len))))
return false;
if (L_WARN_ON(!l_netconfig_set_static_addr(netconfig->nc, af,
rtnl_addr)))
return false;
if (af == AF_INET &&
L_WARN_ON(!l_netconfig_set_acd_enabled(netconfig->nc,
false)))
return false;
/*
* Done with local address, move on to gateway and DNS.
*
* Since load_settings is called early, generally before the actual
* connection setup starts, and load_fils_settings is called after
* 802.11 Authentication & Association, we need to check if either
* the gateway or DNS settings were overridden in load_settings so
* as not to overwrite the user-provided values. Values received
* with FILS are expected to have the same weight as those from
* DHCP/SLAAC.
*
* TODO: If netconfig->fils_override->ipv{4,6}_lifetime is set,
* start a timeout to renew the address using FILS IP Address
* Assignment or perhaps just start the DHCP client after that
* time.
*
* TODO: validate gateway and/or DNS on local subnet, link-local,
* etc.?
*/
if (!netconfig_addr_to_str(af, &fils->ipv4_gateway, &fils->ipv6_gateway,
gw_addr_str, &is_zero))
return false;
if (!netconfig->gateway_overridden[INDEX_FOR_AF(af)] && !is_zero &&
L_WARN_ON(!l_netconfig_set_gateway_override(
netconfig->nc,
af,
gw_addr_str)))
return false;
if (!netconfig_addr_to_str(af, &fils->ipv4_dns, &fils->ipv6_dns,
dns_addr_str, &is_zero))
return is_zero;
if (!netconfig->dns_overridden[INDEX_FOR_AF(af)] && !is_zero) {
char *dns_list[2] = { dns_addr_str, NULL };
if (L_WARN_ON(!l_netconfig_set_dns_override(netconfig->nc,
af, dns_list)))
return false;
}
return true;
}
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
bool netconfig_configure(struct netconfig *netconfig,
netconfig_notify_func_t notify, void *user_data)
{
netconfig: Avoid generating events after netconfig_reset Similarly to l_netconfig track whether IWD's netconfig is active (from the moment of netconfig_configure() till netconfig_reset()) using a "started" flag and avoid handling or emitting any events after "started" is cleared. This fixes an occasional issue with the Netconfig Agent backend where station would reset netconfig, netconfig would issue DBus calls to clear addresses and routes, station would go into DISCONNECTING, perhaps finish and go into DISCONNECTED and after a while the DBus calls would come back with an error which would cause a NETCONFIG_EVENT_FAILED causing station to call netdev_disconnct() for a second time and transition to and get stuck in DISCONNECTING.
2022-10-26 19:58:28 +02:00
if (netconfig->started)
return false;
netconfig: Move loading settings to new method, refactor Split loading settings out of network_configure into a new method, network_load_settings. Make sure both consistently handle errors by printing messages and informing the caller.
2021-08-27 05:02:03 +02:00
netconfig->notify = notify;
netconfig->user_data = user_data;
netconfig: Re-add FILS handling Load the settings from FILS IE data into our l_netconfig instance when appropriate.
2022-08-29 19:35:59 +02:00
if (netconfig_use_fils_addr(netconfig, AF_INET) &&
!netconfig_load_fils_settings(netconfig, AF_INET))
return false;
if (netconfig_use_fils_addr(netconfig, AF_INET6) &&
!netconfig_load_fils_settings(netconfig, AF_INET6))
return false;
netconfig: Handle l_netconfig events Add netconfig_event_handler() that responds to events emitted by the l_netconfig object by calling netconfig_commit, tracking whether we're connected for either address family and emitting NETCONFIG_EVENT_CONNECTED or NETCONFIG_EVENT_FAILED as necessary. NETCONFIG_EVENT_FAILED is a new event as until now failures would cause the netconfig state machine to stop but no event emitted so that station.c could take action. As before, these events are only emitted based on the IPv4 configuration state, not IPv6.
2022-08-29 19:35:58 +02:00
if (unlikely(!l_netconfig_start(netconfig->nc)))
return false;
netconfig: Apply MDNS setting at _configure time
2021-09-29 23:06:52 +02:00
netconfig: Avoid generating events after netconfig_reset Similarly to l_netconfig track whether IWD's netconfig is active (from the moment of netconfig_configure() till netconfig_reset()) using a "started" flag and avoid handling or emitting any events after "started" is cleared. This fixes an occasional issue with the Netconfig Agent backend where station would reset netconfig, netconfig would issue DBus calls to clear addresses and routes, station would go into DISCONNECTING, perhaps finish and go into DISCONNECTED and after a while the DBus calls would come back with an error which would cause a NETCONFIG_EVENT_FAILED causing station to call netdev_disconnct() for a second time and transition to and get stuck in DISCONNECTING.
2022-10-26 19:58:28 +02:00
netconfig->started = true;
netconfig: Decouple from station state Instead of relying on station state changed signal, netconfig introduces three new API calls to configure, re-configure and reset the network configurations. The owner of netconfig object is responsible for initiating the re-configuration of the device depending on its state.
2019-09-30 18:35:51 +02:00
return true;
}
netconfig: Unify static and dynamic addressing APIs
2019-07-17 02:49:47 +02:00
netconfig: netconfig_reconfigure check bool for setting ARP Only set the gateway to the ARP cache if the caller requests.
2021-11-03 23:15:02 +01:00
bool netconfig_reconfigure(struct netconfig *netconfig, bool set_arp_gw)
netconfig: Decouple from station state Instead of relying on station state changed signal, netconfig introduces three new API calls to configure, re-configure and reset the network configurations. The owner of netconfig object is responsible for initiating the re-configuration of the device depending on its state.
2019-09-30 18:35:51 +02:00
{
netconfig: Avoid generating events after netconfig_reset Similarly to l_netconfig track whether IWD's netconfig is active (from the moment of netconfig_configure() till netconfig_reset()) using a "started" flag and avoid handling or emitting any events after "started" is cleared. This fixes an occasional issue with the Netconfig Agent backend where station would reset netconfig, netconfig would issue DBus calls to clear addresses and routes, station would go into DISCONNECTING, perhaps finish and go into DISCONNECTED and after a while the DBus calls would come back with an error which would cause a NETCONFIG_EVENT_FAILED causing station to call netdev_disconnct() for a second time and transition to and get stuck in DISCONNECTING.
2022-10-26 19:58:28 +02:00
if (!netconfig->started)
return false;
netconfig: Try to put gateway mac into ARP cache In certain situations, it is possible for us to know the MAC of the default gateway when DHCP finishes. This is quite typical on many home network and small network setups. It is thus possible to pre-populate the ARP cache with the gateway MAC address to save an extra round trip at connection time. Another advantage is during roaming. After version 4.20, linux kernel flushes ARP caches by default whenever netdev encounters a no carrier condition (as is the case during roaming). This can prevent packets from going out after a roam for a significant amount of time due to lost/delayed ARP responses.
2021-10-14 00:49:18 +02:00
/*
* Starting with kernel 4.20, ARP cache is flushed when the netdev
* detects NO CARRIER. This can result in unnecessarily long delays
* (about 1 second on some networks) due to ARP query response being
* lost or delayed. Try to force the gateway into the ARP cache
* to alleviate this
*/
netconfig: Re-add FILS handling Load the settings from FILS IE data into our l_netconfig instance when appropriate.
2022-08-29 19:35:59 +02:00
if (set_arp_gw) {
netconfig: Add netconfig-commit API Add netconfig-commit.c whose main method, netconfig_commit actually sets the configuration obtained by l_netconfig to the system netdev, specifically it sets local addresses on the interface, adds routes to the routing table, sets DNS related data and may add entries to the neighbor cache. netconfig-commit.c uses a backend-ops type structure to allow for switching backends. In this commit there's only a default backend that uses l_netconfig_rtnl_apply() and a struct resolve object to write the configuration. netconfig_gateway_to_arp is moved from netconfig.c to netconfig-commit.c (and renamed.) The struct netconfig definition is moved to netconfig.h so that both files can access the settings stored in the struct.
2022-08-29 19:35:57 +02:00
netconfig_dhcp_gateway_to_arp(netconfig);
netconfig: Try to put gateway mac into ARP cache In certain situations, it is possible for us to know the MAC of the default gateway when DHCP finishes. This is quite typical on many home network and small network setups. It is thus possible to pre-populate the ARP cache with the gateway MAC address to save an extra round trip at connection time. Another advantage is during roaming. After version 4.20, linux kernel flushes ARP caches by default whenever netdev encounters a no carrier condition (as is the case during roaming). This can prevent packets from going out after a roam for a significant amount of time due to lost/delayed ARP responses.
2021-10-14 00:49:18 +02:00
netconfig: Re-add FILS handling Load the settings from FILS IE data into our l_netconfig instance when appropriate.
2022-08-29 19:35:59 +02:00
if (netconfig->connected[INDEX_FOR_AF(AF_INET)] &&
netconfig_use_fils_addr(netconfig, AF_INET))
netconfig_commit_fils_macs(netconfig, AF_INET);
if (netconfig->connected[INDEX_FOR_AF(AF_INET6)] &&
netconfig_use_fils_addr(netconfig, AF_INET6))
netconfig_commit_fils_macs(netconfig, AF_INET6);
}
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!netconfig->static_config[INDEX_FOR_AF(AF_INET)]) {
netconfig: Don't re-install IPv4 address on re-configure
2019-10-02 01:39:39 +02:00
/* TODO l_dhcp_client sending a DHCP inform request */
netconfig: Decouple from station state Instead of relying on station state changed signal, netconfig introduces three new API calls to configure, re-configure and reset the network configurations. The owner of netconfig object is responsible for initiating the re-configuration of the device depending on its state.
2019-09-30 18:35:51 +02:00
}
netconfig: Add station state watch netconfig is interested in three station states: connected, disconnected and connected after it has roamed. On connected it tries to obtain a new DHCP lease, on disconnected it stops the DHCP client and discards all addresses from interface, on connected after roaming it will try to request a previously issued address.
2019-06-26 00:20:57 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!netconfig->static_config[INDEX_FOR_AF(AF_INET6)]) {
netconfig: Add IPv6 static address installation/removal The network configuration options for IPv6 are grouped under [IPv6] and include the following: ip= ADDRESS/PREFIX gateway=ADDRESS dns=ADDRESS The placeholders for DHCPv6 are placed along the way and marked as TODO items.
2019-10-02 01:44:23 +02:00
/* TODO l_dhcp_v6_client sending a DHCP inform request */
}
netconfig: Add station state watch netconfig is interested in three station states: connected, disconnected and connected after it has roamed. On connected it tries to obtain a new DHCP lease, on disconnected it stops the DHCP client and discards all addresses from interface, on connected after roaming it will try to request a previously issued address.
2019-06-26 00:20:57 +02:00
netconfig: Decouple from station state Instead of relying on station state changed signal, netconfig introduces three new API calls to configure, re-configure and reset the network configurations. The owner of netconfig object is responsible for initiating the re-configuration of the device depending on its state.
2019-09-30 18:35:51 +02:00
return true;
}
bool netconfig_reset(struct netconfig *netconfig)
{
netconfig: Avoid generating events after netconfig_reset Similarly to l_netconfig track whether IWD's netconfig is active (from the moment of netconfig_configure() till netconfig_reset()) using a "started" flag and avoid handling or emitting any events after "started" is cleared. This fixes an occasional issue with the Netconfig Agent backend where station would reset netconfig, netconfig would issue DBus calls to clear addresses and routes, station would go into DISCONNECTING, perhaps finish and go into DISCONNECTED and after a while the DBus calls would come back with an error which would cause a NETCONFIG_EVENT_FAILED causing station to call netdev_disconnct() for a second time and transition to and get stuck in DISCONNECTING.
2022-10-26 19:58:28 +02:00
if (!netconfig->started)
return false;
netconfig->started = false;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
l_netconfig_unconfigure(netconfig->nc);
l_netconfig_stop(netconfig->nc);
netconfig: FILS IP assigment API Add two methods that will allow station to implement FILS IP Address Assigment, one method to decide whether to send the request during association, and fill in the values to be used in the request IE, and another to handle the response IE values received from the server and apply them. The netconfig->rtm_protocol value used when the address is assigned this way remains RTPROT_DHCP because from the user's point of view this is automatic IP assigment by the server, a replacement for DHCP.
2021-08-27 05:02:04 +02:00
netconfig: Handle l_netconfig events Add netconfig_event_handler() that responds to events emitted by the l_netconfig object by calling netconfig_commit, tracking whether we're connected for either address family and emitting NETCONFIG_EVENT_CONNECTED or NETCONFIG_EVENT_FAILED as necessary. NETCONFIG_EVENT_FAILED is a new event as until now failures would cause the netconfig state machine to stop but no event emitted so that station.c could take action. As before, these events are only emitted based on the IPv4 configuration state, not IPv6.
2022-08-29 19:35:58 +02:00
netconfig->connected[0] = false;
netconfig->connected[1] = false;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
netconfig_free_settings(netconfig);
netconfig: Decouple from station state Instead of relying on station state changed signal, netconfig introduces three new API calls to configure, re-configure and reset the network configurations. The owner of netconfig object is responsible for initiating the re-configuration of the device depending on its state.
2019-09-30 18:35:51 +02:00
return true;
netconfig: Add station state watch netconfig is interested in three station states: connected, disconnected and connected after it has roamed. On connected it tries to obtain a new DHCP lease, on disconnected it stops the DHCP client and discards all addresses from interface, on connected after roaming it will try to request a previously issued address.
2019-06-26 00:20:57 +02:00
}
netconfig: Implement netconfig_get_dhcp_server_ipv4 This uses l_dhcp_lease_get_server_id to get the IP of the server that offered us our current lease. l_dhcp_lease_get_server_id returns the vaue of the L_DHCP_OPTION_SERVER_IDENTIFIER option, which is the address that any unicast DHCP frames are supposed to be sent to so it seems to be the best way to get the P2P group owner's IP address as a P2P-client.
2020-07-11 03:00:50 +02:00
char *netconfig_get_dhcp_server_ipv4(struct netconfig *netconfig)
{
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
struct l_dhcp_client *client =
l_netconfig_get_dhcp_client(netconfig->nc);
netconfig: Implement netconfig_get_dhcp_server_ipv4 This uses l_dhcp_lease_get_server_id to get the IP of the server that offered us our current lease. l_dhcp_lease_get_server_id returns the vaue of the L_DHCP_OPTION_SERVER_IDENTIFIER option, which is the address that any unicast DHCP frames are supposed to be sent to so it seems to be the best way to get the P2P group owner's IP address as a P2P-client.
2020-07-11 03:00:50 +02:00
const struct l_dhcp_lease *lease;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (!client)
return NULL;
netconfig: Drop dhcp, dhcp6 and acd client instances In anticipation of switching to use the l_netconfig API, which internally handles DHCPv4, DHCPv6, ACD, etc., drop pointers to instances of l_dhcp_client, l_dhcp6_client and l_acd from struct netconfig. Also drop all code used for handling events from these APIs, including code to commit the received configurations to the system. Committing the final settings to the system netdevs is going to be handled by a new set of utilities in a new file.
2022-08-29 19:35:53 +02:00
lease = l_dhcp_client_get_lease(client);
netconfig: Implement netconfig_get_dhcp_server_ipv4 This uses l_dhcp_lease_get_server_id to get the IP of the server that offered us our current lease. l_dhcp_lease_get_server_id returns the vaue of the L_DHCP_OPTION_SERVER_IDENTIFIER option, which is the address that any unicast DHCP frames are supposed to be sent to so it seems to be the best way to get the P2P group owner's IP address as a P2P-client.
2020-07-11 03:00:50 +02:00
if (!lease)
return NULL;
return l_dhcp_lease_get_server_id(lease);
}
netconfig: FILS IP assigment API Add two methods that will allow station to implement FILS IP Address Assigment, one method to decide whether to send the request during association, and fill in the values to be used in the request IE, and another to handle the response IE values received from the server and apply them. The netconfig->rtm_protocol value used when the address is assigned this way remains RTPROT_DHCP because from the user's point of view this is automatic IP assigment by the server, a replacement for DHCP.
2021-08-27 05:02:04 +02:00
bool netconfig_get_fils_ip_req(struct netconfig *netconfig,
struct ie_fils_ip_addr_request_info *info)
{
/*
* Fill in the fields used for building the FILS IP Address Assigment
* IE during connection if we're configured to do automatic network
* configuration (usually DHCP). If we're configured with static
* values return false to mean the IE should not be sent.
*/
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
if (netconfig->static_config[0] && netconfig->static_config[1])
netconfig: FILS IP assigment API Add two methods that will allow station to implement FILS IP Address Assigment, one method to decide whether to send the request during association, and fill in the values to be used in the request IE, and another to handle the response IE values received from the server and apply them. The netconfig->rtm_protocol value used when the address is assigned this way remains RTPROT_DHCP because from the user's point of view this is automatic IP assigment by the server, a replacement for DHCP.
2021-08-27 05:02:04 +02:00
return false;
memset(info, 0, sizeof(*info));
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
info->ipv4 = !netconfig->static_config[INDEX_FOR_AF(AF_INET)];
info->ipv6 = !netconfig->static_config[INDEX_FOR_AF(AF_INET6)];
info->dns = (info->ipv4 &&
!netconfig->dns_overridden[INDEX_FOR_AF(AF_INET)]) ||
(info->ipv6 &&
!netconfig->dns_overridden[INDEX_FOR_AF(AF_INET)]);
netconfig: FILS IP assigment API Add two methods that will allow station to implement FILS IP Address Assigment, one method to decide whether to send the request during association, and fill in the values to be used in the request IE, and another to handle the response IE values received from the server and apply them. The netconfig->rtm_protocol value used when the address is assigned this way remains RTPROT_DHCP because from the user's point of view this is automatic IP assigment by the server, a replacement for DHCP.
2021-08-27 05:02:04 +02:00
return true;
}
void netconfig_handle_fils_ip_resp(struct netconfig *netconfig,
const struct ie_fils_ip_addr_response_info *info)
{
l_free(netconfig->fils_override);
netconfig->fils_override = l_memdup(info, sizeof(*info));
}
netconfig: Handle l_netconfig events Add netconfig_event_handler() that responds to events emitted by the l_netconfig object by calling netconfig_commit, tracking whether we're connected for either address family and emitting NETCONFIG_EVENT_CONNECTED or NETCONFIG_EVENT_FAILED as necessary. NETCONFIG_EVENT_FAILED is a new event as until now failures would cause the netconfig state machine to stop but no event emitted so that station.c could take action. As before, these events are only emitted based on the IPv4 configuration state, not IPv6.
2022-08-29 19:35:58 +02:00
static void netconfig_event_handler(struct l_netconfig *nc, uint8_t family,
enum l_netconfig_event event,
void *user_data)
{
struct netconfig *netconfig = user_data;
netconfig: Avoid generating events after netconfig_reset Similarly to l_netconfig track whether IWD's netconfig is active (from the moment of netconfig_configure() till netconfig_reset()) using a "started" flag and avoid handling or emitting any events after "started" is cleared. This fixes an occasional issue with the Netconfig Agent backend where station would reset netconfig, netconfig would issue DBus calls to clear addresses and routes, station would go into DISCONNECTING, perhaps finish and go into DISCONNECTED and after a while the DBus calls would come back with an error which would cause a NETCONFIG_EVENT_FAILED causing station to call netdev_disconnct() for a second time and transition to and get stuck in DISCONNECTING.
2022-10-26 19:58:28 +02:00
/* Once stopped, only commit a final L_NETCONFIG_EVENT_UNCONFIGURE */
if (!netconfig->started && event != L_NETCONFIG_EVENT_UNCONFIGURE)
return;
netconfig: Handle l_netconfig events Add netconfig_event_handler() that responds to events emitted by the l_netconfig object by calling netconfig_commit, tracking whether we're connected for either address family and emitting NETCONFIG_EVENT_CONNECTED or NETCONFIG_EVENT_FAILED as necessary. NETCONFIG_EVENT_FAILED is a new event as until now failures would cause the netconfig state machine to stop but no event emitted so that station.c could take action. As before, these events are only emitted based on the IPv4 configuration state, not IPv6.
2022-08-29 19:35:58 +02:00
l_debug("l_netconfig event %d", event);
netconfig_commit(netconfig, family, event);
switch (event) {
case L_NETCONFIG_EVENT_CONFIGURE:
case L_NETCONFIG_EVENT_UPDATE:
break;
case L_NETCONFIG_EVENT_UNCONFIGURE:
break;
case L_NETCONFIG_EVENT_FAILED:
netconfig->connected[INDEX_FOR_AF(family)] = false;
/*
* l_netconfig might have emitted an UNCONFIGURE before this
* but now it tells us it's given up on (re)establishing the
* IP setup.
*/
if (family == AF_INET && netconfig->notify)
netconfig->notify(NETCONFIG_EVENT_FAILED,
netconfig->user_data);
break;
default:
l_error("netconfig: Received unsupported l_netconfig event: %d",
event);
}
}
netconfig: Change public API As a first step to enable the usage of netconfig in ead and prospective transition to be a part of ell, the public API for creation and destruction of the netconfig objects has been renamed and changed. Instead of hiding the netconfig objects inside of netconfig module, the object is now passed back to the caller. The internal queue of netconfig objects remains untouched, due to limitations in ell’s implementation of rtnl. After the proper changes are done to ell, netconfig_list is expected to be removed from netconfig module.
2019-09-27 21:52:17 +02:00
struct netconfig *netconfig_new(uint32_t ifindex)
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
{
netconfig: Start RA & DHCPv6 clients For now the RA client is ran automatically when DHCPv6 client starts. RA takes care of installing / deleting prefix routes and installing the default gateway. If Router Advertisements indicate support DHCPv6, then DHCPv6 transactions are kicked off and the address is set / removed automatically. Stateless configuration is not yet supported.
2020-11-05 16:38:32 +01:00
struct netdev *netdev = netdev_find(ifindex);
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
struct netconfig *netconfig;
netconfig: Add multiple levels to IWD_DHCP_DEBUG Allows granularly specifying the DHCP logging level. This allows the user to tailor the output to what they need. By default, always display info, errors and warnings to match the rest of iwd. Setting `IWD_DHCP_DEBUG` to "debug", "info", "warn", "error" will limit the logging to that level or higher allowing the default logging verbosity to be reduced. Setting `IWD_DHCP_DEBUG` to "1" as per the current behavior will continue to enable debug level logging.
2022-05-18 16:39:14 +02:00
const char *debug_level = NULL;
int dhcp_priority = L_LOG_INFO;
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
struct l_dhcp6_client *dhcp6;
netconfig: Update l_netconfig API calls Since l_netconfig's DHCPv6 client instance no longer sets parameters on the l_icmp6_client instance, call l_icmp6_client_set_nodelay() and l_icmp6_client_set_debug() directly. Also enable optimistic DAD to speed up IPv6 setup if available.
2022-09-20 16:05:08 +02:00
struct l_icmp6_client *icmp6;
netconfig: limit DHCPv4 attempts to avoid extended netconfig times ELL now has a setting to limit the number of DHCP attempts. This will now be set in IWD and if reached will result in a failure event, and in turn a disconnect. IWD will set a maximum of 4 retries which should keep the maximum DHCP time to ~60 seconds roughly.
2024-01-30 18:50:37 +01:00
struct l_dhcp_client *dhcp;
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
l_debug("Creating netconfig for interface: %d", ifindex);
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
netconfig = l_new(struct netconfig, 1);
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
netconfig->nc = l_netconfig_new(ifindex);
netconfig: Store pointer to netdev instead of ifindex To avoid repeated lookups by ifindex, replace the ifindex member in struct netconfig with a struct netdev pointer. A struct netconfig always lives shorter than the struct netdev.
2022-08-29 19:35:56 +02:00
netconfig->netdev = netdev;
resolve: Refactor resolve module Resolve module does not currently track any state that has been set on a per ifindex basis. This was okay while the set of information we supported was quite small. However, with dhcpv6 support being prepared, a more flexible framework is needed. Change the resolve API to allocate and return an instance for a given ifindex that has the ability to track information that was provided.
2020-08-21 21:50:44 +02:00
netconfig->resolve = resolve_new(ifindex);
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
netconfig: Add netconfig-commit API Add netconfig-commit.c whose main method, netconfig_commit actually sets the configuration obtained by l_netconfig to the system netdev, specifically it sets local addresses on the interface, adds routes to the routing table, sets DNS related data and may add entries to the neighbor cache. netconfig-commit.c uses a backend-ops type structure to allow for switching backends. In this commit there's only a default backend that uses l_netconfig_rtnl_apply() and a struct resolve object to write the configuration. netconfig_gateway_to_arp is moved from netconfig.c to netconfig-commit.c (and renamed.) The struct netconfig definition is moved to netconfig.h so that both files can access the settings stored in the struct.
2022-08-29 19:35:57 +02:00
netconfig_commit_init(netconfig);
netconfig: Add multiple levels to IWD_DHCP_DEBUG Allows granularly specifying the DHCP logging level. This allows the user to tailor the output to what they need. By default, always display info, errors and warnings to match the rest of iwd. Setting `IWD_DHCP_DEBUG` to "debug", "info", "warn", "error" will limit the logging to that level or higher allowing the default logging verbosity to be reduced. Setting `IWD_DHCP_DEBUG` to "1" as per the current behavior will continue to enable debug level logging.
2022-05-18 16:39:14 +02:00
debug_level = getenv("IWD_DHCP_DEBUG");
treewide: Comply with doc/coding-style.txt M13
2024-10-14 17:47:30 +02:00
if (debug_level) {
netconfig: Add multiple levels to IWD_DHCP_DEBUG Allows granularly specifying the DHCP logging level. This allows the user to tailor the output to what they need. By default, always display info, errors and warnings to match the rest of iwd. Setting `IWD_DHCP_DEBUG` to "debug", "info", "warn", "error" will limit the logging to that level or higher allowing the default logging verbosity to be reduced. Setting `IWD_DHCP_DEBUG` to "1" as per the current behavior will continue to enable debug level logging.
2022-05-18 16:39:14 +02:00
if (!strcmp("debug", debug_level))
dhcp_priority = L_LOG_DEBUG;
else if (!strcmp("info", debug_level))
dhcp_priority = L_LOG_INFO;
else if (!strcmp("warn", debug_level))
dhcp_priority = L_LOG_WARNING;
else if (!strcmp("error", debug_level))
dhcp_priority = L_LOG_ERR;
else /* Default for backwards compatibility */
dhcp_priority = L_LOG_DEBUG;
}
netconfig: Handle l_netconfig events Add netconfig_event_handler() that responds to events emitted by the l_netconfig object by calling netconfig_commit, tracking whether we're connected for either address family and emitting NETCONFIG_EVENT_CONNECTED or NETCONFIG_EVENT_FAILED as necessary. NETCONFIG_EVENT_FAILED is a new event as until now failures would cause the netconfig state machine to stop but no event emitted so that station.c could take action. As before, these events are only emitted based on the IPv4 configuration state, not IPv6.
2022-08-29 19:35:58 +02:00
l_netconfig_set_event_handler(netconfig->nc, netconfig_event_handler,
netconfig, NULL);
netconfig: limit DHCPv4 attempts to avoid extended netconfig times ELL now has a setting to limit the number of DHCP attempts. This will now be set in IWD and if reached will result in a failure event, and in turn a disconnect. IWD will set a maximum of 4 retries which should keep the maximum DHCP time to ~60 seconds roughly.
2024-01-30 18:50:37 +01:00
dhcp = l_netconfig_get_dhcp_client(netconfig->nc);
l_dhcp_client_set_max_attempts(dhcp, DHCP_ATTEMPTS);
netconfig: Start RA & DHCPv6 clients For now the RA client is ran automatically when DHCPv6 client starts. RA takes care of installing / deleting prefix routes and installing the default gateway. If Router Advertisements indicate support DHCPv6, then DHCPv6 transactions are kicked off and the address is set / removed automatically. Stateless configuration is not yet supported.
2020-11-05 16:38:32 +01:00
netconfig: Keep configuration directly in struct l_netconfig Drop all the struct netconfig members where we were keeping the parsed netconfig settings and add a struct l_netconfig object. In netconfig_load_settings load all of the settings once parsed directly into the l_netconfig object. Only preserve the mdns configuration and save some boolean values needed to properly handle static configuration and FILS. Update functions to use the new set of struct netconfig members. These booleans mirroring the l_netconfig state could be replaced by adding l_netconfig getters for settings which currently only have setters.
2022-08-29 19:35:54 +02:00
dhcp6 = l_netconfig_get_dhcp6_client(netconfig->nc);
netconfig: Drop dhcp, dhcp6 and acd client instances In anticipation of switching to use the l_netconfig API, which internally handles DHCPv4, DHCPv6, ACD, etc., drop pointers to instances of l_dhcp_client, l_dhcp6_client and l_acd from struct netconfig. Also drop all code used for handling events from these APIs, including code to commit the received configurations to the system. Committing the final settings to the system netdevs is going to be handled by a new set of utilities in a new file.
2022-08-29 19:35:53 +02:00
l_dhcp6_client_set_lla_randomized(dhcp6, true);
netconfig: Start RA & DHCPv6 clients For now the RA client is ran automatically when DHCPv6 client starts. RA takes care of installing / deleting prefix routes and installing the default gateway. If Router Advertisements indicate support DHCPv6, then DHCPv6 transactions are kicked off and the address is set / removed automatically. Stateless configuration is not yet supported.
2020-11-05 16:38:32 +01:00
netconfig: Update l_netconfig API calls Since l_netconfig's DHCPv6 client instance no longer sets parameters on the l_icmp6_client instance, call l_icmp6_client_set_nodelay() and l_icmp6_client_set_debug() directly. Also enable optimistic DAD to speed up IPv6 setup if available.
2022-09-20 16:05:08 +02:00
icmp6 = l_netconfig_get_icmp6_client(netconfig->nc);
l_icmp6_client_set_nodelay(icmp6, true);
if (debug_level) {
netconfig: Drop dhcp, dhcp6 and acd client instances In anticipation of switching to use the l_netconfig API, which internally handles DHCPv4, DHCPv6, ACD, etc., drop pointers to instances of l_dhcp_client, l_dhcp6_client and l_acd from struct netconfig. Also drop all code used for handling events from these APIs, including code to commit the received configurations to the system. Committing the final settings to the system netdevs is going to be handled by a new set of utilities in a new file.
2022-08-29 19:35:53 +02:00
l_dhcp6_client_set_debug(dhcp6, do_debug, "[DHCPv6] ", NULL);
netconfig: Update l_netconfig API calls Since l_netconfig's DHCPv6 client instance no longer sets parameters on the l_icmp6_client instance, call l_icmp6_client_set_nodelay() and l_icmp6_client_set_debug() directly. Also enable optimistic DAD to speed up IPv6 setup if available.
2022-09-20 16:05:08 +02:00
l_icmp6_client_set_debug(icmp6, do_debug, "[ICMPv6] ", NULL);
netconfig: limit DHCPv4 attempts to avoid extended netconfig times ELL now has a setting to limit the number of DHCP attempts. This will now be set in IWD and if reached will result in a failure event, and in turn a disconnect. IWD will set a maximum of 4 retries which should keep the maximum DHCP time to ~60 seconds roughly.
2024-01-30 18:50:37 +01:00
l_dhcp_client_set_debug(dhcp, do_debug, "[DHCPv4] ", NULL,
dhcp_priority);
netconfig: Update l_netconfig API calls Since l_netconfig's DHCPv6 client instance no longer sets parameters on the l_icmp6_client instance, call l_icmp6_client_set_nodelay() and l_icmp6_client_set_debug() directly. Also enable optimistic DAD to speed up IPv6 setup if available.
2022-09-20 16:05:08 +02:00
}
netconfig: Start RA & DHCPv6 clients For now the RA client is ran automatically when DHCPv6 client starts. RA takes care of installing / deleting prefix routes and installing the default gateway. If Router Advertisements indicate support DHCPv6, then DHCPv6 transactions are kicked off and the address is set / removed automatically. Stateless configuration is not yet supported.
2020-11-05 16:38:32 +01:00
netconfig: Change public API As a first step to enable the usage of netconfig in ead and prospective transition to be a part of ell, the public API for creation and destruction of the netconfig objects has been renamed and changed. Instead of hiding the netconfig objects inside of netconfig module, the object is now passed back to the caller. The internal queue of netconfig objects remains untouched, due to limitations in ell’s implementation of rtnl. After the proper changes are done to ell, netconfig_list is expected to be removed from netconfig module.
2019-09-27 21:52:17 +02:00
return netconfig;
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
}
netconfig: Change public API As a first step to enable the usage of netconfig in ead and prospective transition to be a part of ell, the public API for creation and destruction of the netconfig objects has been renamed and changed. Instead of hiding the netconfig objects inside of netconfig module, the object is now passed back to the caller. The internal queue of netconfig objects remains untouched, due to limitations in ell’s implementation of rtnl. After the proper changes are done to ell, netconfig_list is expected to be removed from netconfig module.
2019-09-27 21:52:17 +02:00
void netconfig_destroy(struct netconfig *netconfig)
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
{
treewide: Use l_debug with at least one argument By convention we should be passing at least an empty string to make it clearer that no additional debug info is being printed
2019-12-17 23:15:05 +01:00
l_debug("");
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
netconfig: Rework IPv4 address handling Introduce a new v4_address member which will hold the currently configured IPV4 address (static or obtained via DHCP). Use the new l_rtnl_address class for this. As a side-effect, lease expiration will now properly remove the configured address.
2020-11-19 20:52:56 +01:00
netconfig_reset(netconfig);
netconfig: Add netconfig-commit API Add netconfig-commit.c whose main method, netconfig_commit actually sets the configuration obtained by l_netconfig to the system netdev, specifically it sets local addresses on the interface, adds routes to the routing table, sets DNS related data and may add entries to the neighbor cache. netconfig-commit.c uses a backend-ops type structure to allow for switching backends. In this commit there's only a default backend that uses l_netconfig_rtnl_apply() and a struct resolve object to write the configuration. netconfig_gateway_to_arp is moved from netconfig.c to netconfig-commit.c (and renamed.) The struct netconfig definition is moved to netconfig.h so that both files can access the settings stored in the struct.
2022-08-29 19:35:57 +02:00
netconfig_commit_free(netconfig, "aborted");
resolve: Refactor resolve module Resolve module does not currently track any state that has been set on a per ifindex basis. This was okay while the set of information we supported was quite small. However, with dhcpv6 support being prepared, a more flexible framework is needed. Change the resolve API to allocate and return an instance for a given ifindex that has the ability to track information that was provided.
2020-08-21 21:50:44 +02:00
resolve_free(netconfig->resolve);
netconfig: Rename netconfig destructor The old name will be repurposed for the API.
2019-09-27 21:52:16 +02:00
netconfig_free(netconfig);
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
}
treewide: Parse EnableNetworkConfiguration in one place Add netconfig_enabled() and use that in all places that want to know whether network configuration is enabled. Drop the enable_network_config deprecated setting, which was only being handled in one of these 5 or so places.
2021-10-21 10:50:30 +02:00
bool netconfig_enabled(void)
{
bool enabled;
return l_settings_get_bool(iwd_get_config(), "General",
"EnableNetworkConfiguration",
&enabled) && enabled;
}
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
static int netconfig_init(void)
{
treewide: Use CamelCase for netconfig settings
2019-10-25 20:13:40 +02:00
if (!l_settings_get_uint(iwd_get_config(), "Network",
"RoutePriorityOffset",
netconfig: Install connected and gateway routes The routes are installed as a result of a successful installation of the IP addresses. The gateway is fetched with netconfig_ipv4_get_gateway helper function according to the origin of the installed IP address. The route priority offset can be set in main.conf. The default value of 300 is used if the offset isn’t set.
2019-07-31 03:16:12 +02:00
&ROUTE_PRIORITY_OFFSET))
ROUTE_PRIORITY_OFFSET = 300;
netconfig: Add configs for controlling IPV6 support
2020-11-13 22:24:17 +01:00
if (!l_settings_get_bool(iwd_get_config(), "Network",
"EnableIPv6",
&ipv6_enabled))
netconfig: Enable IPV6 support by default
2022-11-17 17:33:02 +01:00
ipv6_enabled = true;
netconfig: Add configs for controlling IPV6 support
2020-11-13 22:24:17 +01:00
netconfig: add global MulticastDNS option Adds the MulticastDNS option globally to main.conf. If set all network connections (when netconfig is enabled) will set mDNS support into the resolver. Note that an individual network profile can still override the global value if it sets MulticastDNS.
2022-11-03 19:54:06 +01:00
mdns_global = l_settings_get_string(iwd_get_config(), "Network",
"MulticastDNS");
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
return 0;
}
static void netconfig_exit(void)
{
netconfig: add global MulticastDNS option Adds the MulticastDNS option globally to main.conf. If set all network connections (when netconfig is enabled) will set mDNS support into the resolver. Note that an individual network profile can still override the global value if it sets MulticastDNS.
2022-11-03 19:54:06 +01:00
l_free(mdns_global);
netconfig: Introduce netconfig module netconfig module will be responsible for the orchestration of the network configuration with the IP addresses. iwd creates one netconfig structure per interface index. The purpose of this struct is to hold all of the interface related addressing states such as: assigned dhcp clients, known addresses, routes, etc.
2019-06-26 00:20:52 +02:00
}
IWD_MODULE(netconfig, netconfig_init, netconfig_exit)
Copy Permalink