GitLab/fluffychat
2
0
Fork 0
mirror of https://gitlab.com/famedly/fluffychat.git synced 2024-11-06 03:59:28 +01:00
Code Issues Projects Releases Wiki Activity

utils/url_launcher: force opening http(s) links in external browser

Browse Source 
The (mobile) platform implementations for url_launcher default to
opening any http(s) link inside a webview instead of the platform
browser. This seems to be a longer-time problem for iOS
(https://gitlab.com/famedly/fluffychat/-/issues/519) but very recently
started to affect Android as well.

Force url_launcher to always use an external application (the browser,
most likely, but possibly other apps might handle those links as well)
as opening links from a messaging app in a webview provides terrible UX.

(For instance a link might lead to some webpage where you start to fill
in some info but then you need to ask someone via the messanger but
can't go back without closing the webview and losing all state. Or if
you happen to re-launch FluffyChat via the home-screen than it goes back
to the home view and the webview state is completely lost as well.)
This commit is contained in:
Marcus Hoffmann 2023-02-18 21:42:09 +01:00
parent a95cd85eb0
commit 9eaaef1048
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/utils/url_launcher.dart
View File

@ -84,7 +84,9 @@ class UrlLauncher {
? 'xn--$hostPartPunycode' ? 'xn--$hostPartPunycode'
: hostPart; : hostPart;
}).join('.'); }).join('.');
launchUrlString(uri.replace(host: newHost).toString()); // Force LaunchMode.externalApplication, otherwise url_launcher will default
// to opening links in a webview on mobile platforms.
launchUrlString(uri.replace(host: newHost).toString(), mode: LaunchMode.externalApplication);
} }
void openMatrixToUrl() async { void openMatrixToUrl() async {