From 044171c0026a8e0771e6c399234bf492d05c309e Mon Sep 17 00:00:00 2001
From: TheOneWithTheBraid <the-one@with-the-braid.cf>
Date: Fri, 2 Jun 2023 18:39:47 +0200
Subject: [PATCH] fix: custom emote placeholder

- place emote loading spinner in the position as the emote itself
- add key to preview in order to ensure proper states aligned

Signed-off-by: TheOneWithTheBraid <the-one@with-the-braid.cf>
---
 lib/pages/chat/input_bar.dart                      |  2 ++
 .../settings_emotes/settings_emotes_view.dart      | 14 +++++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/lib/pages/chat/input_bar.dart b/lib/pages/chat/input_bar.dart
index ecd00c2c..4ed71518 100644
--- a/lib/pages/chat/input_bar.dart
+++ b/lib/pages/chat/input_bar.dart
@@ -263,6 +263,8 @@ class InputBar extends StatelessWidget {
           crossAxisAlignment: CrossAxisAlignment.center,
           children: <Widget>[
             MxcImage(
+              // ensure proper ordering ...
+              key: ValueKey(suggestion['name']),
               uri: suggestion['mxc'] is String
                   ? Uri.parse(suggestion['mxc'] ?? '')
                   : null,
diff --git a/lib/pages/settings_emotes/settings_emotes_view.dart b/lib/pages/settings_emotes/settings_emotes_view.dart
index faee4669..8901143e 100644
--- a/lib/pages/settings_emotes/settings_emotes_view.dart
+++ b/lib/pages/settings_emotes/settings_emotes_view.dart
@@ -212,16 +212,20 @@ class EmotesSettingsView extends StatelessWidget {
 
 class _EmoteImage extends StatelessWidget {
   final Uri mxc;
+
   const _EmoteImage(this.mxc);
 
   @override
   Widget build(BuildContext context) {
     const size = 38.0;
-    return MxcImage(
-      uri: mxc,
-      fit: BoxFit.contain,
-      width: size,
-      height: size,
+    return SizedBox.square(
+      dimension: size,
+      child: MxcImage(
+        uri: mxc,
+        fit: BoxFit.contain,
+        width: size,
+        height: size,
+      ),
     );
   }
 }