Add remove_reader() to SelectHandler and remove unnecessary foreground check from StdinReader's initialize()

PBot/SelectHandler.pm

@@ -35,28 +35,30 @@ sub add_reader {
   $self->{readers}->{$handle} = $sub;
 }
 
+sub remove_reader {
+  my ($self, $handle) = @_;
+  $self->{select}->remove($handle);
+  delete $self->{readers}->{$handle};
+}
+
 sub do_select {
   my ($self) = @_;
   my @ready = $self->{select}->can_read(.5);
   foreach my $fh (@ready) {
-    my $ret = sysread($fh, my $buf, 4096);
+    my $ret = sysread($fh, my $buf, 8192);
 
     if(not defined $ret) {
       $self->{pbot}->logger->log("Error with $fh: $!\n");
-      $self->{select}->remove($fh);
+      $self->remove_reader($fh);
-      delete $self->{readers}->{$fh};
       next;
     }
 
     if($ret == 0) {
-      $self->{pbot}->logger->log("done with $fh\n");
+      $self->remove_reader($fh);
-      $self->{select}->remove($fh);
-      delete $self->{readers}->{$fh};
       next;
     }
 
     chomp $buf;
-    $self->{pbot}->logger->log("read from $fh: [$buf]\n");
 
     if(not exists $self->{readers}->{$fh}) {
       $self->{pbot}->logger->log("Error: no reader for $fh\n");

PBot/StdinReader.pm

@@ -28,7 +28,6 @@ sub initialize {
   # used to check whether process is in background or foreground, for stdin reading
   open TTY, "</dev/tty" or die $!;
   $self->{tty_fd} = fileno(TTY);
-  $self->{foreground} = (tcgetpgrp($self->{tty_fd}) == getpgrp()) ? 1 : 0;
 
   $self->{pbot}->{select_handler}->add_reader(\*STDIN, sub { $self->stdin_reader(@_) });
 }

PBot/VERSION.pm

@@ -13,7 +13,7 @@ use warnings;
 # These are set automatically by the build/commit script
 use constant {
   BUILD_NAME     => "PBot",
-  BUILD_REVISION => 528,
+  BUILD_REVISION => 529,
   BUILD_DATE     => "2014-03-15",
 };