From 7f3650004e221cb80e31ef5fee244f05b2642d54 Mon Sep 17 00:00:00 2001
From: Pragmatic Software <pragma78@gmail.com>
Date: Fri, 23 Jul 2021 10:13:19 -0700
Subject: [PATCH] Utils/PriorityQueue: simplify find_enqueue_position with an
 alias for $self->{queue}

---
 lib/PBot/Utils/PriorityQueue.pm | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/lib/PBot/Utils/PriorityQueue.pm b/lib/PBot/Utils/PriorityQueue.pm
index 778528e7..95c4bf42 100644
--- a/lib/PBot/Utils/PriorityQueue.pm
+++ b/lib/PBot/Utils/PriorityQueue.pm
@@ -55,37 +55,40 @@ sub find_enqueue_position {
 
     $priority //= 0;
 
+    # shorter alias
+    my $queue = $self->{queue};
+
     # no entries in queue yet, early-return first position
-    return 0 if not @{$self->{queue}};
+    return 0 if not @$queue;
 
     # early-return first position if entry's priority is less
     # than first position's
-    if ($priority < $self->{queue}->[0]->{priority}) {
+    if ($priority < $queue->[0]->{priority}) {
         return 0;
     }
 
     # early-return last position if entry's priority is greater
-    if ($priority > $self->{queue}->[@{$self->{queue}} - 1]->{priority}) {
-        return scalar @{$self->{queue}};
+    if ($priority > $queue->[@$queue - 1]->{priority}) {
+        return scalar @$queue;
     }
 
     # binary search to find enqueue position
 
     my $lo = 0;
-    my $hi = scalar @{$self->{queue}} - 1;
+    my $hi = scalar @$queue - 1;
 
     while ($lo <= $hi) {
         my $mid = int (($hi + $lo) / 2);
 
-        if ($priority < $self->{queue}->[$mid]->{priority}) {
+        if ($priority < $queue->[$mid]->{priority}) {
             $hi = $mid - 1;
-        } elsif ($priority > $self->{queue}->[$mid]->{priority}) {
+        } elsif ($priority > $queue->[$mid]->{priority}) {
             $lo = $mid + 1;
         } else {
             # found a slot with the same priority. we "slide" down the array
             # to append this entry to the end of this region of same-priorities
             # and then return the final slot
-            while ($mid < @{$self->{queue}} and $self->{queue}->[$mid]->{priority} == $priority) {
+            while ($mid < @$queue and $queue->[$mid]->{priority} == $priority) {
                 $mid++;
             }
             return $mid;