From 6afabba1838343b756b83b90480648564f7b374d Mon Sep 17 00:00:00 2001 From: Pragmatic Software Date: Tue, 29 Sep 2020 19:22:00 -0700 Subject: [PATCH] Plugins/Plang: update `factget` signature to return `String | Null` --- Plugins/Plang.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Plugins/Plang.pm b/Plugins/Plang.pm index 3b7e4ce3..158079b0 100644 --- a/Plugins/Plang.pm +++ b/Plugins/Plang.pm @@ -58,7 +58,7 @@ sub initialize { [['TYPE', 'String'], 'keyword', undef], [['TYPE', 'String'], 'meta', [['TYPE', 'String'], 'action']] ], - ['TYPE', 'String'], + ['TYPEUNION', [['TYPE', 'String'], ['TYPE', 'Null']]], sub { $self->plang_builtin_factget(@_) }, sub { $self->plang_validate_builtin_factget(@_) }, ); @@ -178,7 +178,11 @@ sub plang_builtin_factget { my ($self, $plang, $context, $name, $arguments) = @_; my ($channel, $keyword, $meta) = ($arguments->[0]->[1], $arguments->[1]->[1], $arguments->[2]->[1]); my $result = $self->{pbot}->{factoids}->get_meta($channel, $keyword, $meta); - return [['TYPE', 'String'], $result]; + if (defined $result) { + return [['TYPE', 'String'], $result]; + } else { + return [['TYPE', 'Null'], undef]; + } } sub plang_validate_builtin_factget {