Plugin/RunCommand: improve pumping and handle lines longer than maximum IRC mesasge length

lib/PBot/Plugin/RunCommand.pm

@@ -55,24 +55,32 @@ sub cmd_runcmd {
     my $lines = 0;
 
     while (pump $h) {
-        if ($out =~ s/^(.*?)\n//) {
+        $lines += $self->send_lines($context, \$out);
-            $self->{pbot}->{conn}->privmsg($context->{from}, $1);
-            $lines++;
-        }
     }
 
     finish $h;
 
-    if (length $out) {
+    $lines += $self->send_lines($context, \$out);
-        my @lines = split /\n/, $out;
 
-        foreach my $line (@lines) {
+    return "No output." if not $lines;
+}
+
+sub send_lines {
+    my ($self, $context, $buffer) = @_;
+
+    my ($line, $lines);
+
+    while ($$buffer =~ s/(.{1,370})//) {
+        $line = $1;
+        $line =~ s/^\s+|\s+$//g;
+
+        if (length $line) {
             $self->{pbot}->{conn}->privmsg($context->{from}, $line);
             $lines++;
         }
     }
 
-    return "No output." if not $lines;
+    return $lines;
 }
 
 1;

lib/PBot/VERSION.pm

@@ -25,8 +25,8 @@ use PBot::Imports;
 # These are set by the /misc/update_version script
 use constant {
     BUILD_NAME     => "PBot",
-    BUILD_REVISION => 4340,
+    BUILD_REVISION => 4341,
-    BUILD_DATE     => "2021-08-02",
+    BUILD_DATE     => "2021-08-04",
 };
 
 sub initialize {}