From 556821805fef0d300de4f2f7b8170781dd3fd4f4 Mon Sep 17 00:00:00 2001
From: Pragmatic Software <pragma78@gmail.com>
Date: Thu, 24 Aug 2017 15:18:41 -0700
Subject: [PATCH] Do not allow empty or too long factoids with `factchange`

---
 PBot/FactoidCommands.pm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/PBot/FactoidCommands.pm b/PBot/FactoidCommands.pm
index eb08e90a..ad8a6ec2 100644
--- a/PBot/FactoidCommands.pm
+++ b/PBot/FactoidCommands.pm
@@ -1220,11 +1220,22 @@ sub factchange {
 
   my $ret = eval {
     use re::engine::RE2 -strict => 1;
-    if(not $factoids->{$channel}->{$trigger}->{action} =~ s|$tochange|$changeto|) {
+    my $action = $factoids->{$channel}->{$trigger}->{action};
+    if(not $action =~ s|$tochange|$changeto|) {
       $self->{pbot}->{logger}->log("($from) $nick!$user\@$host: failed to change '$trigger' 's$delim$tochange$delim$changeto$delim\n");
       return "Change $trigger failed.";
     } else {
+      if (length $action > 400 and not defined $admininfo) {
+        return "Change $trigger failed; result is too long.";
+      }
+
+      if (not length $action) {
+        return "Change $trigger failed; factoids cannot be empty.";
+      }
+
       $self->{pbot}->{logger}->log("($from) $nick!$user\@$host: changed '$trigger' 's/$tochange/$changeto/\n");
+
+      $factoids->{$channel}->{$trigger}->{action}    = $action;
       $factoids->{$channel}->{$trigger}->{edited_by} = "$nick!$user\@$host";
       $factoids->{$channel}->{$trigger}->{edited_on} = gettimeofday;
       $self->{pbot}->{factoids}->save_factoids();