From 2a437b479e8d0954624d72a316880490625b5b5c Mon Sep 17 00:00:00 2001
From: Pragmatic Software <pragma78@gmail.com>
Date: Mon, 30 Dec 2019 14:50:36 -0800
Subject: [PATCH] Logger: reopen logfile after rotation to log final messages

---
 PBot/Logger.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/PBot/Logger.pm b/PBot/Logger.pm
index 7639336e..a25f281c 100644
--- a/PBot/Logger.pm
+++ b/PBot/Logger.pm
@@ -9,6 +9,7 @@ use strict;
 
 use feature 'unicode_strings';
 
+use Scalar::Util qw/openhandle/;
 use File::Basename;
 use Carp ();
 
@@ -48,7 +49,7 @@ sub log {
 
   $text =~ s/(\P{PosixGraph})/my $ch = $1; if ($ch =~ m{[\s]}) { $ch } else { sprintf "\\x%02X", ord $ch }/ge;
 
-  if (defined $self->{logfile}) {
+  if (openhandle *LOGFILE) {
     print LOGFILE "$time :: $text";
   }
 
@@ -59,8 +60,14 @@ sub rotate_log {
   my ($self) = @_;
   my $time = localtime $self->{start};
   $time =~ s/\s+/_/g;
+
+  # logfile has to be closed first for maximum compatibility with `rename`
   close LOGFILE;
   rename $self->{logfile}, $self->{logfile} . '-' . $time;
+
+  # reopen renamed logfile to resume any needed logging
+  open LOGFILE, ">>$self->{logfile}-$time" or Carp::carp "Couldn't re-open logfile $self->{logfile}-$time: $!\n";
+  LOGFILE->autoflush(1) if openhandle *LOGFILE;
 }
 
 1;