3
0
mirror of https://github.com/pragma-/pbot.git synced 2024-12-23 11:12:42 +01:00

Properly handle single-quotes inside of single-quoted text

This commit is contained in:
Pragmatic Software 2010-05-13 23:28:38 +00:00
parent 33a32f29a3
commit 24740da78b

View File

@ -51,10 +51,14 @@ sub execute_module {
my $module = $self->{pbot}->factoids->factoids->{$keyword}{module};
my $module_dir = $self->{pbot}->module_dir;
$self->{pbot}->logger->log("(" . (defined $from ? $from : "(undef)") . "): $nick!$user\@$host: Executing module $module $arguments\n");
$arguments =~ s/\$nick/$nick/g;
$arguments = quotemeta($arguments);
$arguments =~ s/\\\s/ /g;
if(exists $self->{pbot}->factoids->factoids->{$keyword}{modulelauncher_subpattern}) {
if($self->{pbot}->factoids->factoids->{$keyword}{modulelauncher_subpattern} =~ m/s\/(.*?)\/(.*)\//) {
my ($p1, $p2) = ($1, $2);
@ -86,30 +90,27 @@ sub execute_module {
}
}
my $unquoted_args = $arguments;
my $argsbuf = $arguments;
$arguments = "";
while($unquoted_args =~ s/(.*?)('.*)//) {
my $prefix = $1;
my $remainder = $2;
my $lr;
while(1) {
my ($e, $r, $p) = extract_delimited($argsbuf, "'", "[^']+");
$arguments .= quotemeta($prefix);
my ($e, $r) = extract_delimited($remainder, "'");
if(not defined $e) {
$arguments .= quotemeta($r);
} else {
if(defined $e) {
$e =~ s/\\//g;
$e =~ s/'/'\\''/g;
$e =~ s/^'\\''/'/;
$e =~ s/'\\''$/'/;
$arguments .= $p;
$arguments .= $e;
$unquoted_args = $r;
$lr = $r;
} else {
$arguments .= $lr;
last;
}
}
$arguments .= $unquoted_args;
$arguments =~ s/\\\s/ /g;
$arguments =~ s/\\-/-/g;
my $pid = fork;
if(not defined $pid) {
$self->{pbot}->logger->log("Could not fork module: $!\n");