From 1064900f003de9af050980a2ee0d770cb549c9f9 Mon Sep 17 00:00:00 2001 From: Pragmatic Software Date: Wed, 11 Mar 2026 01:03:30 -0700 Subject: [PATCH] Factoids/Interpreter: remove confusing nick-as-argument syntax --- doc/Commands.md | 12 ++++++++++++ lib/PBot/Core/Factoids/Interpreter.pm | 12 ------------ lib/PBot/VERSION.pm | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/doc/Commands.md b/doc/Commands.md index 388c1f2b..31a8b75e 100644 --- a/doc/Commands.md +++ b/doc/Commands.md @@ -221,6 +221,18 @@ Examples: !give mike time mike: It's Sun 31 May 2020 06:03:08 PM PDT in Los Angeles. +You can use redirection with `>`: + + > + +Examples: + + !echo Testing > dave + dave: Testing + + !time > mike + mike: It's Sun 31 May 2020 06:03:08 PM PDT in Los Angeles. + You can use [inline invocation](#inline-invocation), as well -- see the next section. ### Inline invocation diff --git a/lib/PBot/Core/Factoids/Interpreter.pm b/lib/PBot/Core/Factoids/Interpreter.pm index cfda7577..7153930d 100644 --- a/lib/PBot/Core/Factoids/Interpreter.pm +++ b/lib/PBot/Core/Factoids/Interpreter.pm @@ -340,18 +340,6 @@ sub handle_action($self, $context, $action) { $context->{arguments_processed} = 1; $context->{nickprefix_disabled} = 1; - } else { - # set nickprefix if args is a present nick and factoid action doesn't have $nick or $args - if (!$context->{nickprefix_disabled} && $self->{pbot}->{factoids}->{data}->{storage}->get_data($channel, $keyword, 'type') eq 'text') { - my $target = $self->{pbot}->{nicklist}->is_present_similar($context->{from}, $context->{arguments}); - - if ($target and $action !~ /\$\{?(?:nick|args)\b/) { - my $add_nick = $self->{pbot}->{factoids}->{data}->{storage}->get_data($channel, $keyword, 'add_nick'); - unless (defined $add_nick && $add_nick == 0) { - $context->{nickprefix} = $target unless $context->{nickprefix_forced}; - } - } - } } } else { # no arguments supplied diff --git a/lib/PBot/VERSION.pm b/lib/PBot/VERSION.pm index 81a890f4..93db57ba 100644 --- a/lib/PBot/VERSION.pm +++ b/lib/PBot/VERSION.pm @@ -25,8 +25,8 @@ use PBot::Imports; # These are set by the /misc/update_version script use constant { BUILD_NAME => "PBot", - BUILD_REVISION => 4939, - BUILD_DATE => "2026-02-27", + BUILD_REVISION => 4940, + BUILD_DATE => "2026-03-11", }; sub initialize {}