GitHub/pbot
3
0
Fork 0
mirror of https://github.com/pragma-/pbot.git synced 2024-11-25 21:39:27 +01:00
Code Issues Projects Releases Wiki Activity

pbot-vm: fix potential time-out when outputting 0

Browse Source 
If the output from a code snippet is `0` without a newline,
Perl treats this as a false value. When Guest::process_command()
returns a false value, that signals to guest-server::serial_server()
that it is the parent returning and so it will not send the result back
to the host.

However, `0\n` is a true value. Solution: always append a final newline to
the guest output.
This commit is contained in:
Pragmatic Software 2022-03-31 19:52:46 -07:00
parent a98a0fa0fb
commit 03fb901291
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
applets/pbot-vm/guest/lib/Guest.pm
View File

@ -116,7 +116,7 @@ sub process_command($command, $mod, $user, $tag) {
print STDERR "=" x 40, "\n"; print STDERR "=" x 40, "\n";
return $result; return "$result\n";
} else { } else {
# wait for child to finish # wait for child to finish
waitpid($pid, 0); waitpid($pid, 0);

4
lib/PBot/VERSION.pm
View File

@ -25,8 +25,8 @@ use PBot::Imports;
# These are set by the /misc/update_version script # These are set by the /misc/update_version script
use constant { use constant {
BUILD_NAME => "PBot", BUILD_NAME => "PBot",
BUILD_REVISION => 4518, BUILD_REVISION => 4520,
BUILD_DATE => "2022-03-23", BUILD_DATE => "2022-03-31",
}; };
sub initialize {} sub initialize {}